Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies #36619

Closed
wants to merge 1 commit into from
Closed

app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies #36619

wants to merge 1 commit into from

Conversation

salahcoronya
Copy link
Contributor

@salahcoronya salahcoronya commented May 9, 2024 •
edited

Closes: https://bugs.gentoo.org/931513

I'm not expecting a while lot of demand for the excluded TCTIs, but if there are I'm imagining a TPM2_TCTI USE_EXPAND variable may be needed.

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 9, 2024
thesamesam
thesamesam reviewed May 9, 2024
View reviewed changes
app-crypt/tpm2-tss/tpm2-tss-4.1.1-r1.ebuild
doc? ( app-text/doxygen )
"

PATCHES=(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind pulling in the bashism/which patches while at it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added and linked

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm, patch not committed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoopsie! Forget to "git add" the patches! Now fixed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@salahcoronya salahcoronya changed the title app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies [please reassign] May 9, 2024
@gentoo-bot gentoo-bot changed the title app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies [please reassign] app-crypt/tpm2-tss: Exclude TCTIs with automagic external dependencies May 9, 2024
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @salahcoronya
Areas affected: ebuilds
Packages affected: app-crypt/tpm2-tss

app-crypt/tpm2-tss: @salahcoronya, @gentoo/proxy-maint

Linked bugs

Bugs linked: 931513, 931122, 931239

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. and removed assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 9, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-09 18:24 UTC
Newest commit scanned: a1b153a
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f76aedc68f/output.html

@gentoo-bot gentoo-bot closed this in e39e3ae May 9, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-09 22:04 UTC
Newest commit scanned: cadede1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3e2c67a407/output.html

@salahcoronya salahcoronya deleted the tpm2-tss branch May 10, 2024 14:19
@MrDuartePT
Copy link
Contributor

MrDuartePT commented May 13, 2024 •
edited

@salahcoronya, disabling this on app-crypt/tpm2-tss-4.1.1:

		--disable-tcti-spi-ftdi
		--disable-tcti-i2c-ftdi

Breaks tpm2 luks enrolling using clevis:

ERROR:tcti:/var/tmp/portage/app-crypt/tpm2-tss-4.1.1-r1/work/tpm2-tss-4.1.1/src/tss2-tcti/tctildr-dl.c:149:tcti_from_file() Could not initialize TCTI file: device
ERROR:tcti:/var/tmp/portage/app-crypt/tpm2-tss-4.1.1-r1/work/tpm2-tss-4.1.1/src/tss2-tcti/tctildr.c:477:tctildr_init_context_data() Failed to instantiate TCTI
ERROR: Could not load tcti, got: "device:/dev/tpmrm0"
Unable to validate combination of PCR bank 'sha256' and PCR IDs '0,1,2,3,5,6,7'.
Unable to perform encryption with PIN 'tpm2' and config '{"pcr_bank":"sha256","pcr_ids":"0,1,2,3,5,6,7"}'

Why this change was made? Since I don't have problems compiling app-crypt/tpm2-tss-4.1.1

@thesamesam
Copy link
Member

Because it introduced automagic dependencies on libftdi. Please file a bug.

@MrDuartePT
Copy link
Contributor

Ok I gonna do it, I will also try to make a PR to fixit if possible

@MrDuartePT
Copy link
Contributor

MrDuartePT commented May 13, 2024 •
edited

Because it introduced automagic dependencies on libftdi. Please file a bug.

Bug link: https://bugs.gentoo.org/931885

@thesamesam
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesamesam thesamesam thesamesam left review comments

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
5 participants
@salahcoronya @gentoo-bot @gentoo-repo-qa-bot @MrDuartePT @thesamesam