sys-libs/readline: USE=utils: port to modern C (C99) #36621
Conversation
Pull Request assignmentSubmitter: @gabifalk sys-libs/readline: @gentoo/base-system Linked bugsIn order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
| @@ -0,0 +1,291 @@ | |||
| From d09284d53d1a4d1d58207b1240986329285d01ca Mon Sep 17 00:00:00 2001 | |||
There was a problem hiding this comment.
Have you sent this to Chet (ideally on bug-readline)? If so, include a link. If not, please do ;)
(... or, I guess, the version with configure.in, I don't remember if the tarball has it or not; at least making him aware of the problem is important)
There was a problem hiding this comment.
This patch modifies the generated configure script. A proper change for upstream will likely involve porting to a newer version of autoconf. Additionally, I don't have a copyright assignment.
There was a problem hiding this comment.
OK, just send an email reporting it to him then. Chet doesn't ever really apply patches anyway, he just takes inspiration (or not) from them.
Pull request CI reportReport generated at: 2024-05-09 19:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
gabifalk
force-pushed
the
patch-readline-rlfe-c99
branch
from
acc885d
to
72327f2
Compare
Pull request CI reportReport generated at: 2024-05-09 21:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
GCC 14 enables -Werror=implicit-function-declaration and -Werror=implicit-int by default. Closes: https://bugs.gentoo.org/870424 Closes: https://bugs.gentoo.org/919256 Link: https://lists.gnu.org/archive/html/bug-readline/2024-05/msg00000.html Signed-off-by: Gabi Falk <gabifalk@gmx.com>
gabifalk
force-pushed
the
patch-readline-rlfe-c99
branch
from
72327f2
to
d146b47
Compare
Pull request CI reportReport generated at: 2024-05-09 23:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
GCC 14 enables -Werror=implicit-function-declaration and -Werror=implicit-int by default.
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.