Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/openssh: fix implicit function declaraions #36623

Closed
wants to merge 1 commit into from

Conversation

gabifalk
Copy link
Contributor

@gabifalk gabifalk commented May 9, 2024

Fix compilation warning (error with gcc >= 14):

xmss_hash.c: In function ‘core_hash_SHA2’:
xmss_hash.c:56:5: error: implicit declaration of function ‘SHA256’ [-Wimplicit-function-declaration]
56 | SHA256(buf, inlen + keylen + n, out);
| ^~~~~~
xmss_hash.c:61:7: error: implicit declaration of function ‘SHA512’ [-Wimplicit-function-declaration]
61 | SHA512(buf, inlen + keylen + n, out);
| ^~~~~~


Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gabifalk gabifalk force-pushed the fix-openssh-xmss-bug919685 branch from 29a5bd7 to fc61fb1 Compare May 9, 2024 23:13
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @gabifalk
Areas affected: ebuilds
Packages affected: net-misc/openssh

net-misc/openssh: @gentoo/base-system

Linked bugs

Bugs linked: 919685


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 9, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-09 23:34 UTC
Newest commit scanned: fc61fb1
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b992d6b222/output.html

@orbea
Copy link
Contributor

orbea commented May 13, 2024

Was the patch submitted upstream?

@gabifalk
Copy link
Contributor Author

gabifalk commented May 13, 2024

Was the patch submitted upstream?

No, but I made a bugreport and the patch is trivial and obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants