Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mesa gles2 drop fix #36624

Closed
wants to merge 21 commits into from
Closed

Mesa gles2 drop fix #36624

wants to merge 21 commits into from

Conversation

PeakKS
Copy link

@PeakKS PeakKS commented May 10, 2024

Fixes builds with a bunch of packages when mesa does not have the gles2 use flag (currently only mesa-9999)
see bug #929992
see commit 847bd60


Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @PeakKS
Areas affected: ebuilds
Packages affected: dev-debug/apitrace, dev-games/ogre, dev-libs/efl, games-arcade/jazz2, games-engines/scummvm...

@gentoo/github: Too many disjoint maintainers, disabling auto-assignment.

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits. labels May 10, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-10 02:29 UTC
Newest commit scanned: f323d8d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/4d22e1e5cc/output.html

@@ -43,7 +43,7 @@ REQUIRED_USE="
# Dependencies needed by opengl library and plugin (enabled via USE gles2 and/or opengl)
# dmabuf automagic from libdrm headers (drm_fourcc.h) and EGL, so ensure it with USE=egl (platform independent header used only, thus no MULTILIB_USEDEP); provides dmabuf based upload/download/eglimage options
GL_DEPS="
>=media-libs/mesa-9.0[egl(+)?,gbm(+)?,gles2?,wayland?,${MULTILIB_USEDEP}]
>=media-libs/mesa-9.0[egl(+)?,gbm(+)?,gles2(+)?,wayland?,${MULTILIB_USEDEP}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this might need to be a opengl USE dep instead now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm yeah, for some reason I could have sworn it said -Dgles2=true last night but I guess I was just fried.

Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
PeakKS added 19 commits May 16, 2024 16:56
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
Signed-off-by: PeakKS <bbatson101@gmail.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-17 01:45 UTC
Newest commit scanned: 14de3eb
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b37a32bf61/output.html

@parona-source
Copy link
Contributor

parona-source commented May 23, 2024

This would need revisions for all these afaik?

Otherwise a user who wanted the new mesa would have to around manually rebuilding all these packages.

https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html

"Examples of changes that warrant a new revision are: ... * updating a dependency with default on/off USE flags,"

@immolo immolo mentioned this pull request May 23, 2024
4 tasks
@mattst88
Copy link
Contributor

Thanks, a lot of these needed to be fixed in a different way. See commit 4ef522d or be3a1bd for example. I've now fixed them all.

@mattst88 mattst88 closed this May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer-needed There is at least one affected package with no maintainer. Review it if you can. need assignment It was impossible to assign the PR correctly. Please assign it manually. no bug found No Bug/Closes found in the commits.
Projects
None yet
6 participants