Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the GRUB configuration script for memtest86+ EFI builds #36657

Closed
wants to merge 1 commit into from
Closed

Fix the GRUB configuration script for memtest86+ EFI builds #36657

wants to merge 1 commit into from

Conversation

gabrielesvelto
Copy link

The current GRUB configuration script for memtest86+ doesn't produce working entries as it tries to load the executable images using the chainloader command, this fails to load the images.

The executables produced by the build appear to be using the Linux EFI boot stub and thus can be loaded using the linux command instead. This patch does just that.

Closes: https://bugs.gentoo.org/931825

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@gabrielesvelto
Fix the GRUB configuration script for memtest86+ EFI builds
cf17ed4 
The current GRUB configuration script for memtest86+ doesn't produce
working entries as it tries to load the executable images using the
`chainloader` command, this fails to load the images.

The executables produced by the build appear to be using the Linux EFI
boot stub and thus can be loaded using the `linux` command instead. This
patch does just that.

Closes: https://bugs.gentoo.org/931825
Signed-off-by: Gabriele Svelto <gsvelto@mozilla.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @gabrielesvelto
Areas affected: ebuilds
Packages affected: sys-apps/memtest86+

sys-apps/memtest86+: @benkohler

Linked bugs

Bugs linked: 931825

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 12, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-12 16:55 UTC
Newest commit scanned: cf17ed4
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/f3399e473c/output.html

@mattst88 mattst88 requested a review from benkohler May 17, 2024 06:05
@benkohler
Copy link
Contributor

I took your fix and applied it to a new revision so we can easily test the old one should this change cause issues for anyone else. Let me know if r3 doesn't work for you.

@benkohler benkohler closed this May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benkohler benkohler Awaiting requested review from benkohler

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
4 participants
@gabrielesvelto @gentoo-bot @gentoo-repo-qa-bot @benkohler