Add Rust 1.78.0 #36710
Add Rust 1.78.0 #36710
Conversation
Pull Request assignmentSubmitter: @navi-desu dev-lang/rust: @bowlofeggs, @navi-desu, Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
self-maintained
Pull request CI reportReport generated at: 2024-05-17 04:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
I think you forgot to upgrade to llvm-18 in virtual/rust and in LLVM_VALID_SLOTS? |
|
Also the dist useflag doesn't work anymore as it was intended, since the archive files are no longer generated. More info here: rust-lang/rust#124528 |
|
fixed those issues, but noticed i was missing the wasm flag with wasm, it's failing to build with |
Pull request CI reportReport generated at: 2024-05-18 01:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
cc @juippis |
Pull request CI reportReport generated at: 2024-05-20 01:05 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Probably related, Mozilla ebuilds should force a known working rust implementation to be used. |
…refox for LLVM 18, same with bcachefstools
|
I was able to fix the wasm compilation issue by filtering the flags in src_configure, after line 506 -> 506 if use wasm; then
507 # CFLAGS_wasm32_unknown_unknown
508 wasm_target="wasm32-unknown-unknown"
509 export CFLAGS_${wasm_target//-/_}="$(filter-flags '-mcpu*' '-march*' '-mtune*'; echo $CFLAGS)"The code uses the subshell to leave *FLAGS unaltered in the src_configure scope, currently crossdev code does it on its own later, just being safe in case other code is added in between. |
Oh, but I did realize it only applies with |
|
If this is only waiting for firefox, thunderbird and spidermonkey, commit the following to restrict the versions temporarily: virtual/pkgconfig
- !clang? ( >=virtual/rust-1.74 )
- !elibc_glibc? ( dev-lang/rust )
amd64? ( >=dev-lang/nasm-2.14 )
virtual/pkgconfig
+ !clang? (
+ >=virtual/rust-1.74
+ <virtual/rust-1.78
+ )
+ !elibc_glibc? ( <dev-lang/rust-1.78 )
amd64? ( >=dev-lang/nasm-2.14 ) |
|
added the wasm fix, will for firefox et all tomorrow first thing tho, just to be sure, do i add it just for the latest (stable | testing) ebuilds of each? |
Pull request CI reportReport generated at: 2024-05-29 00:10 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Yeah,
|
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Signed-off-by: Anna (navi) Figueiredo Gomes <navi@vlhl.dev>
Pull request CI reportReport generated at: 2024-05-29 21:45 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
| !clang? ( >=virtual/rust-1.65 ) | ||
| !clang? ( | ||
| >=virtual/rust-1.65 | ||
| <virtual/rust-1.78 | ||
| ) | ||
| !elibc_glibc? ( | ||
| || ( | ||
| dev-lang/rust | ||
| <dev-lang/rust-1.78 | ||
| <dev-lang/rust-bin-1.73 | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Hello everyone,
Could someone clarify why this mix of restrictions might be used for !elibc_glibc??
I mean, why not use virtual/rust instead of dev-lang/rust{,-bin} like for !clang? and why rust-bin is limited to <1.73? Similar questions are relevant for other ebuilds.
Thanks!
There was a problem hiding this comment.
You can check git commit history but rust-bin is broken (for reasons unknown, someone needs to investigate it) with musl with newer versions for the purposes of building FF.
spidermonkey/firefox fail to build, seemingly due to nightly features that got removed?
built with and without system-llvm, ripgrep and cbindgen built fine
it also bootstrapped itself fine iirc (will double check tomorrow as well)
missing building with FEATURES=test, will run those tomorrow
don't have any non-x86_64 machines to test that end
Please check all the boxes that apply:
Signed-off-byline to every commit in the pull request.pkgcheck scan --commits --netto check for issues with my commits.Please note that all boxes must be checked for the pull request to be merged.