Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-shells/nushell: make X11 optional #36713

Closed
wants to merge 2 commits into from
Closed

app-shells/nushell: make X11 optional #36713

wants to merge 2 commits into from

Conversation

cjbayliss
Copy link
Contributor

X11 is use for clipboard support on X systems as far as I can tell, but that isn't needed on systems without X.

I also corrected my email address in .mailcap

Please check all the boxes that apply:

  • I can submit this contribution in agreement with the Copyright Policy.
  • I have certified the above via adding a Signed-off-by line to every commit in the pull request.
  • This contribution has not been created with the assistance of Natural Language Processing artificial intelligence tools, in accordance with the AI policy.
  • I have run pkgcheck scan --commits --net to check for issues with my commits.

Please note that all boxes must be checked for the pull request to be merged.

@cjbayliss
mailmap: map my old email address, also sort
69a95a4 
Signed-off-by: Christopher Bayliss <cjbdev@icloud.com>
@cjbayliss
app-shells/nushell: make X11 optional
3be6617 
Signed-off-by: Christopher Bayliss <cjbdev@icloud.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @cjbayliss
Areas affected: ebuilds, other files
Packages affected: app-shells/nushell

app-shells/nushell: @zmedico, @freijon, @gentoo/proxy-maint

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels May 17, 2024
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2024-05-17 07:35 UTC
Newest commit scanned: 3be6617
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/dd54fea83c/output.html

zmedico
zmedico approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@zmedico zmedico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this in the gentoo/stage3:20240513 docker image, without libX11 or libxcb installed, using deps installed from the gentoo binhost. It seems to work fine.

Thanks!

gentoo-bot pushed a commit that referenced this pull request May 19, 2024
@cjbayliss @zmedico
mailmap: map my old email address, also sort
65ed9ea 
Signed-off-by: Christopher Bayliss <cjbdev@icloud.com>
From: #36713
Signed-off-by: Zac Medico <zmedico@gentoo.org>
@cjbayliss cjbayliss deleted the nushell-optional-x11 branch May 25, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmedico zmedico zmedico approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@cjbayliss @gentoo-bot @gentoo-repo-qa-bot @zmedico