Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-text/asciidoc: remove vim-syntax from IUSE #379

Merged

Conversation

marcecj
Copy link
Contributor

@marcecj marcecj commented Nov 20, 2015

The vim-syntax USE flag is useless now, for the following reasons:

  • The actions it controls have no effect, since the Makefile.in doesn't do
    anything vim-related anymore, as mentioned in the CHANGELOG.
  • Vim comes with its own syntax file since version 7.4, which is maintained (by
    AsciiDoc upstream, according to its header) and was last updated in 2014,
    whereas the upstream syntax file has not been changed since 2013.

Gentoo-bug: 530808
Signed-off-by: Marc Joliet marcec@gmx.de

The vim-syntax USE flag is useless now, for the following reasons:

- The actions it controls have no effect, since the Makefile.in doesn't do
  anything vim-related anymore, as mentioned in the CHANGELOG.
- Vim comes with its own syntax file since version 7.4, which is maintained (by
  AsciiDoc upstream, according to its header) and was last updated in 2014,
  whereas the upstream syntax file has not been changed since 2013.

Gentoo-bug: 530808
Signed-off-by: Marc Joliet <marcec@gmx.de>
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

https://qa-reports.gentoo.org/output/gentoo-ci/a33b9cb/5.html#l1951
https://qa-reports.gentoo.org/output/gentoo-ci/a33b9cb/8.html#l201

Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself.

@monsieurp
Copy link
Member

@gentoo/proxy-maint but I'll merge it.

@gentoo-bot gentoo-bot merged commit 168218b into gentoo:master Nov 23, 2015
@marcecj marcecj deleted the app-text_asciidoc_drop_vim-syntax_USE_flag branch November 23, 2015 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants