x11-misc/: Cleanup #4091

Moiman · 2017-03-01T17:26:05Z

gentoo-repo-qa-bot · 2017-03-01T17:28:19Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: x11-misc/basqet, x11-misc/cairo-clock, x11-misc/launchy, x11-misc/qps, x11-misc/qtfm...

x11-misc/basqet: @gentoo/Qt
x11-misc/cairo-clock: @gentoo/desktop-misc
x11-misc/launchy: @gentoo/proxy-maint (maintainer needed)
x11-misc/qps: @gentoo/Qt
x11-misc/qtfm: @gentoo/Qt, @gentoo/desktop-misc
x11-misc/xscreensaver: @gentoo/desktop-misc

SoapGentoo · 2017-03-01T17:59:11Z

x11-misc/basqet/basqet-0.2.0-r1.ebuild

@@ -23,7 +23,11 @@ S=${WORKDIR}/release_${PV}
 PATCHES=( "${FILESDIR}/${P}-desktop.patch" )

 src_prepare() {
-	qt4-r2_src_prepare
+	default
+	eqmake4 ${PN}.pro PREFIX="${EPREFIX}"/usr


you sure eqmake4 should happen in src_prepare?

SoapGentoo · 2017-03-01T18:01:29Z

x11-misc/launchy/launchy-2.5-r1.ebuild

-		plugins/*/*.pro || die "sed failed"
-	qt4-r2_src_prepare
+	default
+	eqmake4 Launchy.pro PREFIX="${EPREFIX}"/usr LIBDIR="$(get_libdir)"


same here, this should be in src_configure

SoapGentoo · 2017-03-01T18:01:56Z

x11-misc/qps/qps-1.10.16-r1.ebuild


-inherit eutils qt4-r2
+inherit qmake-utils


can't remove eutils, needed for newicon and stuff

SoapGentoo · 2017-03-01T18:02:14Z

x11-misc/qps/qps-1.10.16-r1.ebuild

 	sed -i -e '/strip/d' ${PN}.pro || die "sed failed"
+	eqmake4 ${PN}.pro


SoapGentoo · 2017-03-01T18:02:28Z

x11-misc/qtfm/qtfm-5.5-r1.ebuild

+		-e '/MimeType=/s|$|;|' \
+		-e '/Categories=/s|$|;System;FileTools;|' \
+		${PN}.desktop || die
+	eqmake4


SoapGentoo · 2017-03-01T18:04:15Z

x11-misc/xscreensaver/xscreensaver-5.36-r1.ebuild

+	use pam && fperms 755 /usr/bin/${PN}
+	pamd_mimic_system ${PN} auth
+
+	rm -f "${ED}"/usr/share/${PN}/config/{electricsheep,fireflies}.xml


rm -f "${ED%/}"/usr/share/${PN}/config/{electricsheep,fireflies}.xml || die

SoapGentoo · 2017-03-01T18:06:56Z

x11-misc/cairo-clock/files/cairo-clock-0.3.4-linker.patch

+ transform = s/_/-/g
+
+-cairo_clock_LDFLAGS = -Wl, --export-dynamic
+cairo_clock_LDFLAGS = -Wl, -export-dynamic


edit this to remove the space, -Wl, options should never contain a space

Gentoo-Bug: https://bugs.gentoo.org/452106 Package-Manager: Portage-2.3.3, Repoman-2.3.1

Configure step gives following warning otherwise. Warning: GTK version 2.24.31 was found, but at least one supporting library (gdk-pixbuf-xlib-2.0) was not, so GTK can't be used. Perhaps some of the development packages are not installed? Warning: The GTK libraries do not seem to be available; the `xscreensaver-demo' program requires them. Warning: Use of GDK-Pixbuf was requested, but it was not found. The XPM library is being used instead. Some of the demos will not use images as much as they could. You should consider installing GDK-Pixbuf and re-running configure. (GDK-Pixbuf is recommended over XPM, as it provides support for more image formats.) Gentoo-Bug: https://bugs.gentoo.org/608982 Package-Manager: Portage-2.3.3, Repoman-2.3.1

Package-Manager: Portage-2.3.3, Repoman-2.3.1

gentoo-repo-qa-bot · 2017-03-01T19:40:11Z

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/54aa0bd41/output.html#app-portage/g-sorcery

Configure step gives following warning otherwise. Warning: GTK version 2.24.31 was found, but at least one supporting library (gdk-pixbuf-xlib-2.0) was not, so GTK can't be used. Perhaps some of the development packages are not installed? Warning: The GTK libraries do not seem to be available; the `xscreensaver-demo' program requires them. Warning: Use of GDK-Pixbuf was requested, but it was not found. The XPM library is being used instead. Some of the demos will not use images as much as they could. You should consider installing GDK-Pixbuf and re-running configure. (GDK-Pixbuf is recommended over XPM, as it provides support for more image formats.) Gentoo-Bug: https://bugs.gentoo.org/608982 Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

SoapGentoo · 2017-03-01T20:50:20Z

@Moiman maybe you want to join us on IRC so we can chat about your work and how to take it to the next level 😉 (https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers, freenode, #gentoo-proxy-maint)

gentoo-repo-qa-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). labels Mar 1, 2017

SoapGentoo suggested changes Mar 1, 2017

View reviewed changes

Moiman force-pushed the x11-misc-cleanup9 branch from 3c12ee2 to 9d077ae Compare March 1, 2017 18:40

Moiman added 6 commits March 1, 2017 20:42

x11-misc/cairo-clock: EAPI bump 4 -> 6, fix #452106

f6224d7

Gentoo-Bug: https://bugs.gentoo.org/452106 Package-Manager: Portage-2.3.3, Repoman-2.3.1

x11-misc/basqet: EAPI bump 4 -> 6

effc8ab

Package-Manager: Portage-2.3.3, Repoman-2.3.1

x11-misc/launchy: EAPI bump 4 -> 6

9722ddf

Package-Manager: Portage-2.3.3, Repoman-2.3.1

x11-misc/qps: EAPI bump 4 -> 6

5a72bf6

Package-Manager: Portage-2.3.3, Repoman-2.3.1

x11-misc/qtfm: EAPI bump 4 -> 6

cd2f5cc

Package-Manager: Portage-2.3.3, Repoman-2.3.1

Moiman force-pushed the x11-misc-cleanup9 branch from 9d077ae to cd2f5cc Compare March 1, 2017 18:42

SoapGentoo approved these changes Mar 1, 2017

View reviewed changes

gentoo-bot closed this in 5a2369b Mar 1, 2017

gentoo-bot pushed a commit that referenced this pull request Mar 1, 2017

x11-misc/basqet: EAPI bump 4 -> 6

ec07fdb

Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

gentoo-bot pushed a commit that referenced this pull request Mar 1, 2017

x11-misc/launchy: EAPI bump 4 -> 6

b651b69

Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

gentoo-bot pushed a commit that referenced this pull request Mar 1, 2017

x11-misc/qps: EAPI bump 4 -> 6

3302c3b

Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

gentoo-bot pushed a commit that referenced this pull request Mar 1, 2017

x11-misc/qtfm: EAPI bump 4 -> 6

e99d866

Package-Manager: Portage-2.3.3, Repoman-2.3.1 Closes: #4091

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x11-misc/: Cleanup #4091

x11-misc/: Cleanup #4091

Moiman commented Mar 1, 2017 •

edited

gentoo-repo-qa-bot commented Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

SoapGentoo Mar 1, 2017

gentoo-repo-qa-bot commented Mar 1, 2017

SoapGentoo commented Mar 1, 2017

		sed -i -e '/strip/d' ${PN}.pro \|\| die "sed failed"
		eqmake4 ${PN}.pro

x11-misc/: Cleanup #4091

x11-misc/: Cleanup #4091

Conversation

Moiman commented Mar 1, 2017 • edited

gentoo-repo-qa-bot commented Mar 1, 2017

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

SoapGentoo Mar 1, 2017

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Mar 1, 2017

SoapGentoo commented Mar 1, 2017

Moiman commented Mar 1, 2017 •

edited