Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-embedded/arduino: fix #610036 dead SRC_URI googlecode and new EAPI #4157

Closed
wants to merge 3 commits into from

Conversation

madmartin
Copy link
Contributor

Package-Manager: Portage-2.3.3, Repoman-2.3.1

- Bug https://bugs.gentoo.org/show_bug.cgi?id=610036
- changed SRC_URI from googlecode.com to github
- updated ebuild EAPI 4 -> 6

Package-Manager: Portage-2.3.3, Repoman-2.3.1
@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Mar 8, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-embedded/arduino

dev-embedded/arduino: @gentoo/embedded

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

@monsieurp
Copy link
Member

Please file another PR without the last two commits i.e. without merging master back into the branch.

@monsieurp monsieurp closed this Mar 12, 2017
@madmartin
Copy link
Contributor Author

@monsieurp can you please explain why?

@monsieurp
Copy link
Member

Hi. Merging the master branch back into a contribution is considered bad practice and messes up the whole thing altogether. I don't think it was intended, was it? As I said, file the exact same PR and leave it as is.

@madmartin
Copy link
Contributor Author

@monsieurp yes, this was intended, because the qa-bot had tons of complains about things I have never touched. On my first PR I was told to exactly do that what you disliked - update branch from master and push again, which calmed the qa-bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
3 participants