Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-python/neovim-python-client: add python 3.6 to PYTHON_COMPAT #4266

Closed
wants to merge 1 commit into from
Closed

dev-python/neovim-python-client: add python 3.6 to PYTHON_COMPAT #4266

wants to merge 1 commit into from

Conversation

lluixhi
Copy link
Contributor

@lluixhi lluixhi commented Mar 20, 2017 •
edited

versions previous to neovim-python-client-0.1.13 don't work.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Mar 20, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/neovim-python-client, virtual/python-greenlet

dev-python/neovim-python-client: @gentoo/vim, @gentoo/Python
virtual/python-greenlet: @gentoo/Python

@lluixhi
Copy link
Contributor Author

lluixhi commented May 7, 2017

@monsieurp
Could you merge this? Python 3.6 is officially supported in 0.1.13, and there should no longer be any dependency issues.
https://github.com/neovim/python-client/releases/tag/0.1.13

@mgorny
Copy link
Member

mgorny commented May 11, 2017

Please fix the issues reported by the CI.

@lluixhi
Copy link
Contributor Author

lluixhi commented May 12, 2017

Fixed.

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

mgorny
mgorny requested changes May 18, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that upstream repo has some tests. Any reason you're not using them?

@lluixhi
Copy link
Contributor Author

lluixhi commented May 19, 2017

Done. I'm not sure why the original writer did not include the tests, but they will be run now.

@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#app-emulation/crossover-office-bin
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#app-emulation/crossover-office-pro-bin
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#dev-java/jdbc-oracle-bin
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#dev-java/sun-j2ee-deployment-bin
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#dev-ml/ppx_bench
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#dev-ruby/ruby-gdkpixbuf2
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#sci-biology/mammoth
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#sci-chemistry/ambertools
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#sci-chemistry/gamess
https://qa-reports.gentoo.org/output/gentoo-ci/fd5a8ebd5/output.html#sci-chemistry/mead

mgorny
mgorny approved these changes May 27, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'm going to test and merge.

@mgorny mgorny self-assigned this May 27, 2017
@mgorny
Copy link
Member

mgorny commented May 27, 2017 

RepoMan scours the neighborhood...
  KEYWORDS.dropped              1
   dev-python/neovim-python-client/neovim-python-client-0.1.13.ebuild: x86
  RDEPEND.suspect               1
   dev-python/neovim-python-client/neovim-python-client-0.1.13.ebuild: 'test?' USE conditional in RDEPEND

Plus, tests seem to require neovim installed. I'll fix it for you this time.

@lluixhi lluixhi deleted the neovim-python-client branch May 30, 2017 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees

@mgorny mgorny

Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
Milestone
No milestone
3 participants
@lluixhi @gentoo-repo-qa-bot @mgorny