Idea ultimate #428
Idea ultimate #428
Conversation
|
😞 The QA check for this pull request has found the following issues: https://qa-reports.gentoo.org/output/gentoo-ci/f1e333f/3.html#l1077 Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself. |
|
Not having yet entered the branch, I wonder about Need await a reply from the Proxy maintainer. Seeing your interest in this package, are you both content for tomboy-64 to be added as a co-maintainer? |
|
@idella In commit 6ddc60e you can see: ...idea-ultimate-15.0.2.143.870.1_pre.ebuild → ...dea-ultimate-15.0.2.143.1015.7_pre.ebuild |
kensington
added
the
assigned
| make_wrapper "${PN}" "${dir}/bin/${MY_PN}.sh" | ||
| make_wrapper "${PN}" "${dir}/bin/${MY_PN}.sh" || die | ||
| newicon "bin/${MY_PN}.png" "${PN}.png" || die | ||
| make_desktop_entry "${PN}" "IntelliJ Idea Ultimate" "${PN}" "Development;IDE;" || die |
There was a problem hiding this comment.
All those dies are superfluous as the eclass die on their own.
There was a problem hiding this comment.
This is the reason I do not react any more on Gentoo, each push request of the same ebuild with newer versions there are problems that are created by the comments on the previous push requests! Get your rules straight!
There was a problem hiding this comment.
These rules are there since years. Could you please point me where you have been corrected the other way round?
There was a problem hiding this comment.
I can't find it, but I had to place those || die everywhere. I believe those are the rules, but you do not agree with each other and it is getting very annoying and took much of my time.
There was a problem hiding this comment.
I reviewed your reviews and could find it either.
The rules are simple:
- all helper function (
econf,emake,doins...) die alone - all eclass function in EAPI >=5 die alone e.g.
make_desktop_entryfrom eutils.eclass - all system commands must have a die e.g.
mkdir,rm,cd,chmod,ln...
|
😞 The QA check for this pull request has found the following issues: https://qa-reports.gentoo.org/output/gentoo-ci/5fb0a14/output.html#dev-db/xtrabackup-bin Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself. |
tomboy-64
force-pushed
the
idea-ultimate
branch
from
8e08620
to
9416aed
Compare
|
@jlec incorporated your suggestions |
|
😞 The QA check for this pull request has found the following issues: https://qa-reports.gentoo.org/output/gentoo-ci/65bed16/output.html#app-admin/testdisk Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself. |
|
ok I see it now. It was deleted |
|
@tomboy-64 thanks |
tomboy-64
force-pushed
the
idea-ultimate
branch
from
d9955ba
to
faabd46
Compare
|
😞 The QA check for this pull request has found the following issues: https://qa-reports.gentoo.org/output/gentoo-ci/0a23226/output.html#app-admin/testdisk Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself. |
|
😞 The QA check for this pull request has found the following issues: https://qa-reports.gentoo.org/output/gentoo-ci/a7f15fe/output.html#app-admin/testdisk Please note that the issues may come from the underlying Gentoo repository state rather than the pull request itself. |
|
jlec yes. |
|
@idella sure. I'd be willing to co-maintain, unless someone objects. |
Review by jlec, adjustments made accordingly Pull request: #428
|
merged |
|
thanks :) |
@switch87
@github/proxy-maint