net-libs/libsrsirc: New package #4355
Conversation
A lightweight, cross-platform IRC library Written in portable standard C (C99) Gentoo-bug: 602354 Package-Manager: Portage-2.3.3, Repoman-2.3.1
gentoo-repo-qa-bot
added
new package
|
Pull Request assignment Areas affected: ebuilds net-libs/libsrsirc: @gentoo/proxy-maint (new package) |
There was a problem hiding this comment.
Can you also add a static-libs USE flag, pass --disable-static to econf unless that USE flag is enabled, remove the .la file in src_install using the command find "${D}" -name '*.la' -delete || die as explained here: https://wiki.gentoo.org/wiki/Project:Quality_Assurance/Handling_Libtool_Archives
If this is just a library, why is it installing icat and iwat in /usr/bin?
| @@ -0,0 +1,24 @@ | |||
| # Copyright 1999-2017 Gentoo Foundation | |||
| # Distributed under the terms of the GNU General Public License v2 | |||
| # $Id$ | |||
There was a problem hiding this comment.
This looks like something repoman could check.
|
|
||
| EAPI=6 | ||
|
|
||
| inherit eutils |
There was a problem hiding this comment.
No functionality from eutils is used, so it should be removed as well
|
|
Package-Manager: Portage-2.3.3, Repoman-2.3.1
Package-Manager: Portage-2.3.3, Repoman-2.3.1
|
You don't have to remove them, I just wondered. |
|
|
||
| src_configure() { | ||
| use static-libs && econf $(use_with ssl) | ||
| ! use static-libs && econf --disable-static $(use_with ssl) |
There was a problem hiding this comment.
use_enable should just work here, no?
There was a problem hiding this comment.
Sorry, let me clarify. You can do (not tested):
src_configure() {
econf $(use_with ssl) $(use_enable static-libs static)
}
There was a problem hiding this comment.
That would do --enable-static in case static-libs is set. Which is slightly different to what you asked for.
There was a problem hiding this comment.
Now that I think about it that's probably the correct way.
Package-Manager: Portage-2.3.3, Repoman-2.3.1
|
Merged in 564c213...1d9a135. Thanks! I've squashed your commits prior to merging and made some minor visual changes. |
A lightweight, cross-platform IRC library
Written in portable standard C (C99)
Gentoo-bug: 602354
Package-Manager: Portage-2.3.3, Repoman-2.3.1