dev-util/android-ndk: bump to 14b #4479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package-Manager: Portage-2.3.3, Repoman-2.3.1
gentoo-repo-qa-bot
added
the
assigned
|
Pull Request assignment Areas affected: ebuilds dev-util/android-ndk: @perfinion |
mgorny
reviewed
May 7, 2017
| ANDROID_PATH="${ANDROID_PATH}:${ANDROID_PREFIX}/${i}" | ||
| done | ||
|
|
||
| printf '%s' \ |
There was a problem hiding this comment.
Is this a fancy way of saying echo "foo"?
There was a problem hiding this comment.
Yes. That's true. See e5d5076.
Package-Manager: Portage-2.3.5, Repoman-2.3.1
mgorny
reviewed
May 11, 2017
|
|
||
| echo "SEARCH_DIRS_MASK=\"${EPREFIX}/${ANDROID_NDK_DIR}\"" > "${T}/80${PN}" || die | ||
| insinto "/etc/revdep-rebuild" | ||
|
|
There was a problem hiding this comment.
I would also kill this empty line. It makes it quite confusing that you have echo and insinto in one block but the actual doins in another. But this is something that can be easily fixed while merging, so no need to push a fix.
mgorny
added
the
fix on merge
|
commit 38a2cd2 Thanks for the patch! committed :D Sorry I didnt notice the PR earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package-Manager: Portage-2.3.3, Repoman-2.3.1