Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys-apps/nix: Fix small grammar issues in doc contents #4493

Closed
wants to merge 2 commits into from
Closed

sys-apps/nix: Fix small grammar issues in doc contents #4493

wants to merge 2 commits into from

Conversation

kennyballou
Copy link
Contributor

Package-Manager: Portage-2.3.3, Repoman-2.3.1

@kennyballou
sys-apps/nix: Fix small grammar issues in doc contents
6d99678 
Package-Manager: Portage-2.3.3, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: sys-apps/nix

sys-apps/nix: @trofi

@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Apr 25, 2017
@mgorny mgorny requested a review from trofi April 26, 2017 19:19
mgorny
mgorny approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I'd use a second opinion from a native speaker ;-).

@trofi
Copy link
Contributor

trofi commented Apr 26, 2017

Looks about right. I didn't know about the consonant sounds rule. https://english.stackexchange.com/questions/4700/is-it-a-uniform-or-an-uniform

You might like to bring sys-apps/guix in sync as well as they both contain roughly the same info text.

@kennyballou
Copy link
Contributor Author

I'll craft another commit for sys-apps/guix... unless it's preferred to squish them together in this case.

@kennyballou
sys-apps/guix: Fix small grammar issues in doc contents
0882756 
Package-Manager: Portage-2.3.3, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/9fc29024a/output.html#sys-cluster/cinder

@trofi
Copy link
Contributor

trofi commented Apr 26, 2017

Looks fine. Thank you!

@gentoo-bot gentoo-bot closed this in aa8677a May 7, 2017
@kennyballou kennyballou deleted the nix-doc-grammar-fixes branch May 7, 2017 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

@trofi trofi trofi approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
Milestone
No milestone
4 participants
@kennyballou @gentoo-repo-qa-bot @trofi @mgorny