Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-im/slack-bin: change license #4533

Closed
wants to merge 5 commits into from
Closed

net-im/slack-bin: change license #4533

wants to merge 5 commits into from

Conversation

SpiderX
Copy link
Contributor

@SpiderX SpiderX commented May 2, 2017

  1. License changed (bug #615466).
  2. Slack 2.3.4 and 2.4.2 dropped, 2.1.2 kept as the last one with x86 support.
  3. Ebuild fixes backported from 2.5.2 to 2.1.2.
  4. Metadata cleanup.

Package-Manager: Portage-2.3.5, Repoman-2.3.1

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-im/slack-bin

net-im/slack-bin: @SpiderX, @gentoo/proxy-maint

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 2, 2017
mgorny
mgorny requested changes May 7, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are really not things you should mix in a single commit, especially when it's involving such a major changes as retroactive license fix. Please split this into separate logical commits.

@mgorny
Copy link
Member

mgorny commented May 24, 2017

Ping.

@mgorny mgorny added the work in progress The PR is not yet ready to be merged. label May 24, 2017
@SpiderX
net-im/slack-bin: drop old ebuilds
a9cfa30 
1. Metadata cleanup.
2. Slack 2.3.4 and 2.4.2 dropped, 2.1.2 kept as the last one with x86 support.

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@SpiderX
net-im/slack-bin: modify slack 2.1.2
0fe583a 
1. Ebuild fixes backported to 2.1.2

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@SpiderX
net-im/slack-bin: change license
4f1a94e 
1. License changed (bug #615466)

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@SpiderX
Copy link
Contributor Author

SpiderX commented Jul 3, 2017

@mgorny Sorry for a delay.
The previous commit was split.
Please, review.

@mgorny mgorny removed the work in progress The PR is not yet ready to be merged. label Jul 5, 2017
mgorny
mgorny requested changes Jul 5, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more small changes needed.

Also, please make summaries more descriptive since that's the only thing people see in shortlogs. There's really no point in having one change noted in extended body if it would fully fit within the summary line.

net-im/slack-bin/slack-bin-2.1.2.ebuild Outdated
fperms +x /opt/${MY_PN}/${MY_PN}
dosym /opt/${MY_PN}/${MY_PN} /usr/bin/${MY_PN}
}

pkg_preinst() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is no longer necessary with the current gnome2-utils.eclass.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed from all ebuilds.

net-im/slack-bin/slack-bin-2.1.2.ebuild Outdated
QA_PREBUILT="opt/slack/slack
opt/slack/resources/app.asar.unpacked/node_modules/*
opt/slack/libnode.so
opt/slack/libgcrypt.so.11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to unbundle it? We have dev-libs/libgcrypt:11 for this library specifically.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libgcrypt.so.11 is not needed anymore.
I missed this when I was backporting fixes from newer ebuilds.
Removed it from 2.1.2

net-im/slack-bin/slack-bin-2.5.2.ebuild
@@ -11,11 +11,11 @@ DESCRIPTION="Team collaboration tool"
HOMEPAGE="http://www.slack.com/"
SRC_URI="https://downloads.slack-edge.com/linux_releases/${MY_PN}-desktop-${PV}-amd64.deb"

LICENSE="no-source-code"
LICENSE="all-rights-reserved"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logically belongs before the backport ;-P.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I know... )

@SpiderX
net-im/slack-bin: ebuild bump
8def6e9 
1. Bump ebuild to 2.6.3 (bug #619592)

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@SpiderX
net-im/slack-bin: remove pkg_preinst() section
64eb1e3 
Package-Manager: Portage-2.3.6, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#app-backup/bacula
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#app-i18n/ibus
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#dev-games/ogre
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#media-libs/raspberrypi-userland
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#media-sound/snd
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#sci-chemistry/icm
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#sys-auth/nss-pam-ldapd
https://qa-reports.gentoo.org/output/gentoo-ci/532cfff6e/output.html#sys-cluster/ceph

@gktrk gktrk assigned gktrk and unassigned gktrk Jul 6, 2017
mgorny
mgorny approved these changes Jul 11, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, ok, I'll reorder them for you ;-P.

@mgorny
Copy link
Member

mgorny commented Jul 11, 2017 

  ebuild.absdosym               3
   net-im/slack-bin/slack-bin-2.1.2.ebuild: dosym '/opt/${MY_PN}/${MY_PN}'... could use relative path on line: 69
   net-im/slack-bin/slack-bin-2.5.2.ebuild: dosym '/opt/${MY_PN}/${MY_PN}'... could use relative path on line: 67
   net-im/slack-bin/slack-bin-2.6.3.ebuild: dosym '/opt/${MY_PN}/${MY_PN}'... could use relative path on line: 67

I'm going to accept it this time but please fix it ASAP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@SpiderX @gentoo-repo-qa-bot @mgorny @gktrk