net-im/mattermost-desktop-bin: version bump to 3.7.0 #4625
Conversation
|
Pull Request assignment Areas affected: ebuilds net-im/mattermost-desktop-bin: @mhz-tamb, @monsieurp, @gentoo/proxy-maint |
gentoo-repo-qa-bot
added
self-maintained
| HOMEPAGE="https://about.mattermost.com/" | ||
|
|
||
| SRC_URI=" | ||
| https://github.com/mattermost/desktop/archive/v${PV}.tar.gz -> ${P}.tar.gz |
| doins *.pak *.bin *.dat | ||
|
|
||
| exeinto "/opt/${MY_PN}" | ||
|
|
|
|
||
| doexe *.so "${MY_PN}" | ||
|
|
||
| dosym "/opt/${MY_PN}/${MY_PN}" "/usr/bin/${MY_PN}" |
There was a problem hiding this comment.
Please do not use absolute symlinks. Make it a relative symlink instead (use relative path in first arg).
| } | ||
|
|
||
| pkg_preinst() { | ||
| gnome2_icon_savelist |
There was a problem hiding this comment.
This is no longer needed these days.
|
thank you! it's okay now? |
| x86? ( https://releases.mattermost.com/desktop/${PV}/mattermost-desktop-${PV}-linux-ia32.tar.gz ) | ||
| " | ||
|
|
||
| LICENSE="Apache-2.0" |
There was a problem hiding this comment.
AFAICS this bundles a number of libraries (libffmpeg, libnode…). You need to include licenses for them as well.
| SLOT="0" | ||
| KEYWORDS="~amd64 ~x86" | ||
|
|
||
| RESTRICT="mirror" |
There was a problem hiding this comment.
Is there a specific reason for the mirroring restriction? I don't think the license requires that.
| x86? ( https://releases.mattermost.com/desktop/${PV}/mattermost-desktop-${PV}-linux-ia32.tar.gz ) | ||
| " | ||
|
|
||
| LICENSE="Apache-2.0 GPL v2+ LGPL-2.1+ MIT" |
There was a problem hiding this comment.
Those LICENSE thingies have to correspond to files from /licenses directory.
| exeinto "/opt/${MY_PN}" | ||
| doexe *.so "${MY_PN}" | ||
|
|
||
| dosym "../../opt/${MY_PN}/${MY_PN}" "/usr/bin/${MY_PN}" |
There was a problem hiding this comment.
I'm sorry for noticing this earlier but is there any reason it's not installed in /opt/bin? That's where we usually create symlinks for apps in /opt.
| @@ -40,7 +42,7 @@ src_install() { | |||
| exeinto "/opt/${MY_PN}" | |||
| doexe *.so "${MY_PN}" | |||
|
|
|||
| dosym "../../opt/${MY_PN}/${MY_PN}" "/usr/bin/${MY_PN}" | |||
| dosym "../../opt/${MY_PN}/${MY_PN}" "/opt/bin/${MY_PN}" | |||
There was a problem hiding this comment.
Now you can shorten the relative path.
No description provided.