-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net-p2p/ppcoind: Fix building with GCC-6 and bump to use EAPI 6 #4691
Conversation
Bug: https://bugs.gentoo.org/show_bug.cgi?id=594404 Package-Manager: Portage-2.3.5, Repoman-2.3.2
Pull Request assignment Areas affected: ebuilds net-p2p/ppcoind: @gentoo/proxy-maint (maintainer needed) |
IUSE="examples ipv6 logrotate upnp" | ||
|
||
RDEPEND=" | ||
dev-libs/boost[threads(+)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if boost is needed at runtime, it 99% needs :=
|
||
if has_version '>=dev-libs/boost-1.52'; then | ||
sed -i 's/\(-l db_cxx\)/-l boost_chrono$(BOOST_LIB_SUFFIX) \1/' src/makefile.unix | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just make this unconditional (or if you'd like to do me a favour, turn it into an unconditional patch)
OPTS+=("BDB_LIB_SUFFIX=-${DB_VER}") | ||
|
||
cd src || die | ||
emake CC="$(tc-getCC)" CXX="$(tc-getCXX)" -f makefile.unix "${OPTS[@]}" ${PN} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of cd src
'ing, just try adding -C src
to the emake
line
Package-Manager: Portage-2.3.5, Repoman-2.3.2
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Peter-Levine splendid work, as always 😄
Package-Manager: Portage-2.3.5, Repoman-2.3.2 Closes: #4691
Bug: https://bugs.gentoo.org/show_bug.cgi?id=594404
Package-Manager: Portage-2.3.5, Repoman-2.3.2
Upstream PR: peercoin/peercoin#122