Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-p2p/ppcoind: Fix building with GCC-6 and bump to use EAPI 6 #4691

Closed
wants to merge 2 commits into from

Conversation

Peter-Levine
Copy link
Contributor

Bug: https://bugs.gentoo.org/show_bug.cgi?id=594404
Package-Manager: Portage-2.3.5, Repoman-2.3.2

Upstream PR: peercoin/peercoin#122

@gentoo-repo-qa-bot gentoo-repo-qa-bot added the maintainer-needed There is at least one affected package with no maintainer. Review it if you can. label May 20, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-p2p/ppcoind

net-p2p/ppcoind: @gentoo/proxy-maint (maintainer needed)

@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label May 20, 2017
@Peter-Levine Peter-Levine changed the title net-p2p/ppcoind: Fix building with GCC-6 net-p2p/ppcoind: Fix building with GCC-6 and bump to use EAPI 6 May 20, 2017
IUSE="examples ipv6 logrotate upnp"

RDEPEND="
dev-libs/boost[threads(+)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if boost is needed at runtime, it 99% needs :=


if has_version '>=dev-libs/boost-1.52'; then
sed -i 's/\(-l db_cxx\)/-l boost_chrono$(BOOST_LIB_SUFFIX) \1/' src/makefile.unix
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just make this unconditional (or if you'd like to do me a favour, turn it into an unconditional patch)

OPTS+=("BDB_LIB_SUFFIX=-${DB_VER}")

cd src || die
emake CC="$(tc-getCC)" CXX="$(tc-getCXX)" -f makefile.unix "${OPTS[@]}" ${PN}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of cd src'ing, just try adding -C src to the emake line

Package-Manager: Portage-2.3.5, Repoman-2.3.2
Copy link
Member

@SoapGentoo SoapGentoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Peter-Levine splendid work, as always 😄

gentoo-bot pushed a commit that referenced this pull request May 26, 2017
Package-Manager: Portage-2.3.5, Repoman-2.3.2
Closes: #4691
@Peter-Levine Peter-Levine deleted the bug-594404 branch May 26, 2017 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). maintainer-needed There is at least one affected package with no maintainer. Review it if you can.
Projects
None yet
3 participants