Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-misc/boinc: Support CURL_SSL="gnutls" #4732

Closed
wants to merge 2 commits into from

Conversation

Yamakuzure
Copy link
Contributor

@Yamakuzure Yamakuzure commented May 23, 2017

Gentoo-Bug: 619032

Enabling gnutls USE flag on curl broke boinc ability to
connect to WorldCommunityGrid (WCG) servers.

This situation seems to have changed, as I have no problem
connecting to WCG using CURL_SSL="gnutls" any more.

Further both suspend and resume do not work any more.
The reason is, that fetching the project URLs requires password
authentication now.

The init script was fixed to use the appropriate authentication.

Package-Manager: portage-2.3.6

@jlec @SoapGentoo Please have a look whether you are fine with this.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: sci-misc/boinc

sci-misc/boinc: @Yamakuzure, @gentoo/sci

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels May 23, 2017
@Yamakuzure Yamakuzure force-pushed the master branch 2 times, most recently from 26a13f0 to 97c3d78 Compare May 23, 2017 16:17
Gentoo-Bug: 619032

Enabling gnutls USE flag on curl broke boinc ability to
connect to WorldCommunityGrid (WCG) servers.

This situation seems to have changed, as I have no problem
connecting to WCG using CURL_SSL="gnutls" any more.

Package-Manager: portage-2.3.6
Both suspend and resume do not work any more, at least with boinc-7.6.33.
The reason is, that fetching the project URLs require password authentication.

This commit adds the required steps to no longer get an authentication error
when trying to suspend/resume boinc.

Package-Manager: portage-2.3.6
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a regression so I'm going to merge this. However, the init.d script is full of bashisms and OpenRC uses any POSIX-ish shell, so it's going to fail randomly for people having non-bash /bin/sh. Please look into fixing that.

@mgorny
Copy link
Member

mgorny commented Jun 4, 2017

Two more notes:

  • this change is strictly bound with new (reintroduced?) USE flag, so a revbump is unnecessary. People who have it disabled don't need to rebuild, and people who want to enable it will get it via --changed-use/--newuse;
  • 'tags' in commit messages go to the end, and Gentoo-Bug: NNNNNN form makes no sense. Either put a full URI in Bug: https://bugs.gentoo.org/NNNNNN or just short #NNNNNN in summary line.

I'll fix both for you.

@mgorny
Copy link
Member

mgorny commented Jun 4, 2017

(revbump makes sense for the init.d change though; but it should've happened in that commit)

@gentoo-bot gentoo-bot closed this in 2563ac2 Jun 4, 2017
@Yamakuzure
Copy link
Contributor Author

@mgorny Thank you very much for your help and your suggestions. I'll keep them in mind when I fix the init script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants