app-forensics/aide: verbump to 0.16 #4735
Conversation
|
Pull Request assignment Areas affected: ebuilds app-forensics/aide: @gentoo/forensics |
gentoo-repo-qa-bot
added
the
assigned
| dev-libs/libgcrypt:0= | ||
| dev-libs/libgpg-error | ||
| ) | ||
| mhash? ( app-crypt/mhash ) |
There was a problem hiding this comment.
Sort, plox? I suppose you did that on purpose but having it on top looks weird anyway.
There was a problem hiding this comment.
mhash USE is special so it goes first. The rest is alphabetical.
| --with-confighmactype="sha512" # Override default weak MD5 hash. | ||
| --with-dbhmackey="sha512" # Override default weak MD5 hash. | ||
| # Disable broken l10n support: https://sourceforge.net/p/aide/bugs/98/ | ||
| # This doesn't affect anything because there are no localizations yet. |
There was a problem hiding this comment.
'yet' sounds funny for software that old.
There was a problem hiding this comment.
It's on their todo.
| # This doesn't affect anything because there are no localizations yet. | ||
| --without-locale | ||
| $(use_enable static) | ||
| $(use_with zlib) |
There was a problem hiding this comment.
Do those options have any specific order?
There was a problem hiding this comment.
Yes. This is how they are ordered in configure{,.ac}.
| [AC_HELP_STRING([--with-mmap], | ||
| [use mmap @<:@default=check@:>@])], | ||
| - [], | ||
| + [with_mmap="$withval"], |
There was a problem hiding this comment.
I'm pretty sure this is unnecessary.
https://www.gnu.org/software/autoconf/manual/autoconf-2.60/html_node/External-Software.html
The option's argument is available to the shell commands action-if-given in the shell variable withval, which is actually just the value of the shell variable with_package, with any - characters changed into ‘_’. You may use that variable instead, if you wish.
There was a problem hiding this comment.
This is needed for posix-acl configure option that maps to acl USE.
Then I went ahead and updated other options with this pattern to match the rest.
There was a problem hiding this comment.
configure before:
# Check whether --with-mmap was given.
if test "${with_mmap+set}" = set; then :
withval=$with_mmap;
else
with_mmap=check
fi
configure after (with your patch):
# Check whether --with-mmap was given.
if test "${with_mmap+set}" = set; then :
withval=$with_mmap; with_mmap="$withval"
else
with_mmap=check
fi
|
Please also cover modernizing the old stable, or at least killing confutils inherit there. |
I see no point. It's halfway broken and that codebase is very old. It should just die once 0.16 is stabilized. |
| [AC_HELP_STRING([--with-posix-acl], | ||
| [use POSIX ACLs (no checking)])], | ||
| - [], | ||
| + [with_posix_acl_support="$withval"], |
There was a problem hiding this comment.
Alternative suggestion: maybe just update other places in the code to use $with_posix_acl variable as defined by autoconf? ;-)
app-forensics/aide/metadata.xml
Outdated
| <maintainer type="project"> | ||
| <email>forensics@gentoo.org</email> |
There was a problem hiding this comment.
Oh, please do not remove forensics. Keeping it is safer politically ;-).
There was a problem hiding this comment.
And yes, I don't want to be a primary maintainer at least for now.
Notable ebuild changes: - fix deps; - fix broken static USE; - add e2fs USE to check file attributes on ext2/ext3/ext4; - drop broken and completely useless nls USE; - modernize ebuild, EAPI=6; - drop useless dodoc, dohtml, fowners, fperms calls; - stop repeating to users about example configuration; - cleanup patches and send them upstream. Package-Manager: Portage-2.3.6, Repoman-2.3.2
Package-Manager: Portage-2.3.6, Repoman-2.3.2
Closes: #4735 Package-Manager: Portage-2.3.6, Repoman-2.3.2
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
|
Thank you, @mgorny. |
No description provided.