Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev-util/vint: revbump to add setuptools to RDEPEND #4833

Closed
wants to merge 1 commit into from
Closed

dev-util/vint: revbump to add setuptools to RDEPEND #4833

wants to merge 1 commit into from

Conversation

Coacher
Copy link
Contributor

@Coacher Coacher commented Jun 2, 2017

See vint/linting/cli.py

Package-Manager: Portage-2.3.6, Repoman-2.3.2

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-util/vint

dev-util/vint: @Coacher, @gentoo/proxy-maint

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jun 2, 2017
mgorny
mgorny requested changes Jun 4, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I've heard we're raising the bar for ya. Please adjust the commit message to focus on the key change. 'Revbump' is a side effect, implication of the change. Adding dependency is what the commit message should be about.

@Coacher
Copy link
Contributor Author

Coacher commented Jun 4, 2017

So I've heard we're raising the bar for ya.

Says who?

@mgorny
Copy link
Member

mgorny commented Jun 4, 2017

Says who?

Said the 'let's see who's getting recruited' list ;-).

@Coacher
dev-util/vint: add setuptools to RDEPEND
a169395 
See vint/linting/cli.py

Package-Manager: Portage-2.3.6, Repoman-2.3.2
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#app-emulation/openstack-guest-agents-unix
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#sci-biology/mammoth
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#sci-chemistry/ambertools
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#sci-chemistry/gamess
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#sci-chemistry/mead
https://qa-reports.gentoo.org/output/gentoo-ci/cce94b002/output.html#sys-libs/suacomp

mgorny
mgorny approved these changes Jun 4, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@gentoo-bot gentoo-bot closed this in d58800f Jun 4, 2017
@Coacher
Copy link
Contributor Author

Coacher commented Jun 4, 2017

Thank you, @mgorny.

@Coacher Coacher deleted the vint-fix-deps branch June 4, 2017 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
3 participants
@Coacher @gentoo-repo-qa-bot @mgorny