dev-lang/nasm: bump to 2.13.01, EAPI=6, fix doc dependencies #4938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package-Manager: Portage-2.3.6, Repoman-2.3.2
gentoo-repo-qa-bot
added
the
need assignment
|
Pull Request assignment Areas affected: ebuilds dev-lang/nasm: At least one of the listed packages is maintained entirely by non-GitHub developers! |
SoapGentoo
suggested changes
Jun 18, 2017
dev-lang/nasm/metadata.xml
Outdated
| @@ -15,5 +15,6 @@ Pentium, P6, MMX, 3DNow!, SSE and SSE2 opcodes, and has macro capability. | |||
| </longdescription> | |||
| <upstream> | |||
| <remote-id type="sourceforge">nasm</remote-id> | |||
| <bugs-to>https://bugzilla.nasm.us/</bugs-to> | |||
There was a problem hiding this comment.
did you run xmllint on this?
There was a problem hiding this comment.
I blame vim! (I didn't see that the original had spaces and my vim config uses tabs for those files, which is Gentoo's default I guess).
dev-lang/nasm/nasm-2.13.01.ebuild
Outdated
| " | ||
|
|
||
| S=${WORKDIR}/${P/_} | ||
| DOCS=( AUTHORS CHANGES ChangeLog README TODO ) |
There was a problem hiding this comment.
all of these are part of the default set?
dev-lang/nasm/nasm-2.13.01.ebuild
Outdated
| src_install() { | ||
| emake INSTALLROOT="${D}" install install_rdf | ||
| if use doc; then | ||
| DOCS+=( doc/nasmdoc.{pdf,txt} ) |
There was a problem hiding this comment.
rather just do dodoc doc/nasmdoc.{pdf,txt} here and nix the prior DOCS definition
Gentoo-Bug: 619360 Package-Manager: Portage-2.3.6, Repoman-2.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related bug: https://bugs.gentoo.org/show_bug.cgi?id=619360
I added some missing dependencies and removed texinfo which isn't required.
I will make a rekeywording bug for the arches that do not have the new deps once this is merged.