dev-libs/{wlc,sway}: version bumps #5224
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-repo-qa-bot
added
self-maintained
|
Pull Request assignment Areas affected: ebuilds dev-libs/sway: @Hummer12007, @gentoo/proxy-maint |
SoapGentoo
suggested changes
Jul 30, 2017
dev-libs/wlc/wlc-9999.ebuild
Outdated
| @@ -29,7 +29,10 @@ RDEPEND="virtual/opengl | |||
| x11-libs/xcb-util-image | |||
| x11-libs/xcb-util-wm | |||
| x11-libs/libXfixes ) | |||
| xwayland? ( x11-base/xorg-server[wayland] ) | |||
| xwayland? ( x11-libs/libxcb[xkb] | |||
There was a problem hiding this comment.
multi-dep conditionals should always be done like
xwayland? (
x11-libs/libxcb[xkb]
x11-libs/xcb-util-image
x11-libs/xcb-util-wm
x11-base/xorg-server[wayland]
)
as that makes it easier for the eye to find the end
There was a problem hiding this comment.
Fixed & rebased
further separated X and xwayland USE flags enabled USE xwayland by default
added tray USE flag for tray icon support
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 30, 2017
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 30, 2017
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 30, 2017
added tray USE flag for tray icon support Closes: #5224
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 30, 2017
gentoo-bot
pushed a commit
that referenced
this pull request
Jul 30, 2017
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.