www-client/luakit: new package #5228

lluixhi · 2017-07-27T20:02:05Z

luakit is an easily extensible WebKit-based browser written in lua.

This version uses Webkit 2 and GTK+ 3

This package was originally in the tree before but was abandoned because the maintainer quit in ~2012.

A new maintainer took it up and this is the first release.

Hummer12007 · 2017-07-27T21:26:30Z

Do you mind adding a live version as well? (9999)
It might be quite useful, considering the fact that it's still under active development.

SoapGentoo · 2017-07-30T10:11:01Z

www-client/luakit/luakit-2017.07.26.ebuild

+	virtual/pkgconfig
+	doc? ( app-doc/doxygen )"
+
+DOCS=()


is there a reason to suppress default DOCS?

I'm supressing default DOCS because the Makefile installs the documentation already during the install stage:
https://github.com/aidanholm/luakit/blob/develop/Makefile#L91-L96

I wouldn't bother, tons of buildsystems do this, yet we dont mind. Stay as vanilla as possible.

Also FYI, COPYING.GPLv3 shouldn't be installed

Yeah I just noticed that. I guess I'll just rm it.

lluixhi · 2017-07-31T18:11:35Z

@Hummer12007
Yeah I can add a live ebuild.

lluixhi · 2017-07-31T18:33:54Z

@SoapGentoo
By the way, luakit installs files to "/etc/xdg/luakit" and ignores the prefix variable in that case.
The variable that I would need to change for install is called XDGPREFIX -- do you know how I can make it Gentoo Prefix friendly? Should I just add a line:
XDGPREFIX="${EPREFIX}/etc/xdg"?

SoapGentoo · 2017-07-31T18:46:22Z

@lluixhi as a stopgap you can do that. If you care a lot about this package, the proper way of course is to Autotool/CMake/Meson-ise it and not fiddle with internal variables.

Hummer12007 · 2017-07-31T20:11:12Z

www-client/luakit/luakit-9999.ebuild

+
+if [[ ${PV} == 9999 ]]; then
+	inherit git-r3
+	EGIT_REPO_URI="git://github.com/aidanholm/luakit.git"


aidanholm has transitioned to the luakit account as the new upstream (merged), iirc

Oh nice, I'll change the links.

Hummer12007 · 2017-07-31T20:13:13Z

www-client/luakit/luakit-9999.ebuild

+inherit toolchain-funcs
+
+DESCRIPTION="A fast, light, simple to use micro-browser using WebKit and Lua."
+HOMEPAGE="https://aidanholm.github.io/luakit/"


HOMEPAGE should be luakit.org

http://luakit.org redirects to https://luakit.github.io/luakit, so I think I'll use that instead, I think Gentoo is trying to use more https links in homepages and such.

mgorny

Just a minor nitpick. I'm going to try to build it, and if it passes tests, I'll fix it and commit.

mgorny · 2017-08-03T14:37:07Z

www-client/luakit/luakit-2017.07.26.ebuild

+
+inherit toolchain-funcs
+
+DESCRIPTION="A fast, light, simple to use micro-browser using WebKit and Lua."


It's not a proper sentence so no . at the end.

mgorny

>>> Test phase: www-client/luakit-2017.07.26
make -j3 LUA_BIN_NAME=lua run-tests 
x86_64-pc-linux-gnu-gcc-5.4.0 -fpic -march=k8-sse3 -mcx16 -msahf --param l1-cache-size=64 --param l1-cache-line-size=64 --param l2-cache-size=512 -O2 -pipe -frecord-gcc-switches -std=gnu99 -W -Wall -Wextra -pthread -I/usr/include/webkitgtk-4.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/luajit-2.0 -I/usr/include/webkitgtk-4.0 -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I./  -DVERSION=\"5bdc45fa\" -DDEVELOPMENT_PATHS -shared -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu  -Wl,--export-dynamic -lgthread-2.0 -pthread -lwebkit2gtk-4.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lsqlite3 -lluajit-5.1 -ljavascriptcoregtk-4.0 -lglib-2.0 tests/util.c -o tests/util.so
lua: error loading module 'tests.util' from file './tests/util.so':
	./tests/util.so: undefined symbol: g_dir_make_tmp
stack traceback:
	[C]: ?
	[C]: in function 'require'
	tests/run_test.lua:15: in main chunk
	[C]: ?
make: *** [Makefile:125: run-tests] Error 1

mgorny · 2017-08-03T15:34:12Z

This indicates a wrong linker line. The source file should come before all the -l arguments; otherwise -Wl,--as-needed strips them.

lluixhi · 2017-08-04T18:58:24Z

I'll write a patch for it and submit it upstream.
Sorry about that, last time I tested it I didn't get any linker issues, but it might've just been luck.

mgorny · 2017-08-06T10:55:54Z

@lluixhi, how's the patch going? If you need help, just lemme know. Otherwise, please leave upstream report/patch link. This is the kind of issue that Gentoo developers hit frequently, and that sometimes needs some convincing upstream.

lluixhi · 2017-08-09T18:17:49Z

Finally made the patch.
luakit/luakit#418

lluixhi · 2017-08-09T18:39:21Z

I also missed a couple of things that were required for the test phase:
test phase requires dev-lua/luassert and x11-base/xorg-server[xvfb].
It also requires dev-lua/luacheck but that's not currently in the tree, so I made the test phase nonfatal for now (unless I should just let it fail)

currently, it'll just skip the tests if built with luajit because dev-lua/luassert and dev-lua/say can only be built for lua and not luajit at the moment.

I also fixed the installation paths because for some reason DOCDIR and XDGPREFIX aren't respecting DESTDIR.

Hummer12007 · 2017-08-09T23:44:28Z

www-client/luakit/luakit-2017.07.26.ebuild

+
+src_test() {
+	# We're currently missing luacheck which is necessary to pass all tests
+	nonfatal emake \


You can specify RESTRICT="luajit? ( test )" (i.e. use-conditional)

mgorny · 2017-08-10T07:25:26Z

Could you also package luacheck while at it? Lua packages aren't usually hard to do, and that would certainly improve things.

mgorny

I think it's almost good. Just let me know if you agree with adding := on lua since different versions are going to be incompatible, and i'll add that minor fix, test it and push. No need for you to update the ebuilds, that will only make more work for CI ;-).

mgorny · 2017-08-11T12:49:31Z

dev-lua/luacheck/luacheck-0.20.0.ebuild

+
+RDEPEND="
+	dev-lua/luafilesystem[luajit=]
+	!luajit? ( >=dev-lang/lua-5.1 )


I think you really ought to use := for lua.

Just FYI, I don't think luakit has been tested on lua 5.2 or 5.3, and I'm pretty sure the author makes no guarantees of it working with them. Woud <dev-lang/lua-5.2:= be a better version dependency?

But yes, I agree with adding := otherwise.

< dependencies are a very bad thing™, because they prevent upgrades. Do not use them unless the thing actually does not work. Using := also guarantees that the package will be rebuilt on Lua upgrade, so if anything starts failing at build time, people will notice instantly.

I just realized we're commenting on luacheck. Whoops.
That makes sense though.

mgorny · 2017-08-11T12:52:07Z

www-client/luakit/luakit-2017.08.10.ebuild

+	virtual/pkgconfig
+	doc? ( app-doc/doxygen )
+	test? (
+		dev-lua/luassert


It's not strictly necessary but if you have some spare time, feel free to also submit a PR adding luajit flag here. However, I won't delay luakit because of that.

Hold up, I'm adding commits for luassert and say so I can add that.

mgorny · 2017-08-13T09:20:21Z

dev-lua/say/say-1.3_p1-r1.ebuild

+	instdir="$($(tc-getPKG_CONFIG) --variable INSTALL_LMOD $(usex luajit 'luajit' 'lua'))"/${PN}
+	insinto "${instdir#${EPREFIX}}"
+	doins src/init.lua
+	einstalldocs


This doesn't seem to match the original set of docs installed.

mgorny · 2017-08-13T09:21:59Z

dev-lua/luassert/luassert-1.7.10.ebuild

+	instdir="$($(tc-getPKG_CONFIG) --variable INSTALL_LMOD $(usex luajit 'luajit' 'lua'))"/${PN}
+	insinto "${instdir#${EPREFIX}}"
+	doins -r src/*
+	einstalldocs


Also reverted.

mgorny · 2017-08-13T09:22:49Z

dev-lua/luacheck/luacheck-0.20.0.ebuild

+
+	newbin bin/luacheck.lua luacheck
+
+	einstalldocs


You may also want to include CHANGELOG.md.

Done. I also added a doc use flag to build and install the HTML sphinx documentation.

gentoo-repo-qa-bot · 2017-08-13T09:57:05Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-lua/luacheck, dev-lua/luassert, dev-lua/say, www-client/luakit

dev-lua/luacheck: @gentoo/proxy-maint (new package)
dev-lua/luassert: @williamh
dev-lua/say: @williamh
www-client/luakit: @gentoo/proxy-maint (new package)

lluixhi · 2017-08-23T18:27:33Z

@mgorny
Made the changes you suggested, can this be merged now?

mgorny · 2017-08-23T18:57:01Z

>>> Emerging (10 of 11) dev-lua/luacheck-0.20.0::gentoo
 * luacheck-0.20.0.tar.gz SHA256 SHA512 WHIRLPOOL size ;-) ...                                                                              [ ok ]
>>> Unpacking source...
>>> Unpacking luacheck-0.20.0.tar.gz to /tmp/portage/dev-lua/luacheck-0.20.0/work
>>> Source unpacked in /tmp/portage/dev-lua/luacheck-0.20.0/work
>>> Preparing source in /tmp/portage/dev-lua/luacheck-0.20.0/work/luacheck-0.20.0 ...
>>> Source prepared.
>>> Configuring source in /tmp/portage/dev-lua/luacheck-0.20.0/work/luacheck-0.20.0 ...
>>> Source configured.
>>> Compiling source in /tmp/portage/dev-lua/luacheck-0.20.0/work/luacheck-0.20.0 ...
 * ERROR: dev-lua/luacheck-0.20.0::gentoo failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 115:  Called src_compile
 *   environment, line 942:  Called die
 * The specific snippet of code:
 *       use doc && sphinx-build docsrc html || die
 * 
 * If you need support, post the output of `emerge --info '=dev-lua/luacheck-0.20.0::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=dev-lua/luacheck-0.20.0::gentoo'`.
 * The complete build log is located at '/var/log/portage/dev-lua:luacheck-0.20.0:20170823-185530.log'.
 * For convenience, a symlink to the build log is located at '/tmp/portage/dev-lua/luacheck-0.20.0/temp/build.log'.
 * The ebuild environment file is located at '/tmp/portage/dev-lua/luacheck-0.20.0/temp/environment'.
 * Working directory: '/tmp/portage/dev-lua/luacheck-0.20.0/work/luacheck-0.20.0'
 * S: '/tmp/portage/dev-lua/luacheck-0.20.0/work/luacheck-0.20.0'

mgorny · 2017-08-23T18:57:45Z

(and that's why people are supposed to use if;fi and not ugly one-liners)

lluixhi · 2017-08-23T20:50:28Z

That's embarassing. I tested it with the doc flag enabled but I didn't test with it disabled and I didn't have the presence of mind to remember order of evaluation for and/or.

Anyway, fixed.

Bump to EAPI 6 Add Test phase. Gentoo-Bug: https://bugs.gentoo.org/628758

Bump to EAPI 6 Add Test phase Gentoo-Bug: https://bugs.gentoo.org/628758

lluixhi · 2017-08-25T18:36:14Z

Added test phases as per https://bugs.gentoo.org/628758

gentoo-repo-qa-bot · 2017-08-25T18:58:20Z

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/e8c169264/output.html#media-sound/snd
https://qa-reports.gentoo.org/output/gentoo-ci/e8c169264/output.html#sys-devel/binutils-hppa64

mgorny · 2017-09-02T08:43:36Z

I'm afraid I don't have good news for you.

Starting Xvfb
PASS style/test_widgets / test_widgets_use_macros
PASS style/test_source_format / test_header_comment
PASS style/test_source_format / test_lua_module_functions_are_documented
PASS style/test_source_format / test_lua_module_uses_M
PASS style/test_source_format / test_no_tabs_in_indentation
PASS style/test_source_format / test_lua_header
PASS style/test_source_format / test_no_trailing_whitespace
PASS style/test_source_format / test_vim_modeline
PASS style/test_source_format / test_include_guard
PASS style/test_luacheck / test_luacheck
PASS style/test_documentation / test_module_blurb_not_empty
PASS style/test_common / test_no_globalconf_in_common
PASS async/test_widget / test_widget_of_invalid_type_fails
PASS async/test_widget / test_webview_widget_privacy
PASS async/test_widget / test_bin_widget_set_child
FAIL async/test_undoclose / test_undo_close_works
  Timed out while waiting for signal 'load-status'
    interval was 5000msec
    
  Traceback:
  (1) tests/lib.lua:26                  in function wait_for_view
  (2) tests/async/test_undoclose.lua:22 in function [anonymous]
FAIL async/test_undoclose / test_undo_close_restores_tab_history
  tests/async/test_undoclose.lua:66: Expected objects to be equal.
  Passed in:
  (number) 2
  Expected:
  (number) 3
  Traceback:
  (1) /usr/share/lua/5.1/luassert/assert.lua:51 in function is_equal
  (2) tests/async/test_undoclose.lua:66         in function [anonymous]
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  libva info: VA-API version 0.40.0
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
WAIT async/test_scroll / test_scrolling_works
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  [    1.554004] E [core/common/lualib]: Lua error: unable to load image file: Failed to open file '/usr/share/luakit/resources/icons/tab-icon-page.png': No such file or directory
                   Traceback:
                   (1) [C]                     in function filename
                   (2) lib/tab_favicons.lua:44 in function [anonymous]
WAIT async/test_scroll / test_scrolling_works
  [    1.760604] E [core/common/lualib]: Lua error: unable to load image file: Failed to open file '/usr/share/luakit/resources/icons/tab-icon-page.png': No such file or directory
                   Traceback:
                   (1) [C]                     in function filename
                   (2) lib/tab_favicons.lua:44 in function [anonymous]
PASS async/test_scroll / test_scrolling_works
PASS async/test_module_binds_have_descriptions / test_module_binds_have_descriptions
PASS async/test_memory_leaks / test_webview_from_closed_tab_is_released
PASS async/test_lua_files_load_successfully / test_all_lua_files_load_successfully
PASS async/test_lib_lousy_util / test_lousy_util_table_toarray
PASS async/test_lib_lousy_util / test_lousy_util_table_join
PASS async/test_lib_lousy_util / test_lousy_util_table_reverse
PASS async/test_lib_lousy_util / test_lousy_util_table_filter_array
PASS async/test_lib_lousy_util / test_lousy_util_lua_escape
PASS async/test_lib_lousy_util / test_lousy_util_table_isclone
PASS async/test_lib_lousy_util / test_lousy_util_table_copy_clone
PASS async/test_lib_lousy_uri / test_lousy_uri_parse
PASS async/test_lib_lousy_uri / test_lousy_uri_properties
FAIL async/test_image_css / test_image_css
  tests/async/test_image_css.lua:26: bad argument #2 to 'format' (string expected, got table)
  Traceback:
  (1) tests/async/test_image_css.lua:26 in function view_wait_for_status
  (2) tests/async/test_image_css.lua:44 in function [anonymous]
PASS async/test_http_test_server / test_http_server_returns_file_contents
PASS async/test_config / test__config_rc_loads_successfully
PASS async/test_completion / test_leaving_completion_restores_correct_input_text
PASS async/test_clib_sqlite3 / test_module
PASS async/test_clib_sqlite3 / test_compile_statement
PASS async/test_clib_sqlite3 / test_sqlite3_exec
PASS async/test_clib_sqlite3 / test_open_db
PASS async/test_clib_soup / test_set_proxy_uri
PASS async/test_clib_soup / test_set_accept_policy
PASS async/test_clib_soup / test_set_cookies_storage
PASS async/test_clib_soup / test_soup
PASS async/test_clib_regex / test_regex_with_no_pattern_fails
PASS async/test_clib_regex / test_regex_matches
PASS async/test_clib_regex / test_module
PASS async/test_clib_luakit / test_windows_table
RUN  async/test_clib_luakit / test_website_data
  Error loading module '/usr/lib/nsbrowser/plugins/libflashplayer.so': /usr/lib/nsbrowser/plugins/libflashplayer.so: wrong ELF class: ELFCLASS32
  Error scanning plugin /usr/lib/nsbrowser/plugins/libflashplayer.so, /usr/libexec/webkit2gtk-4.0/WebKitPluginProcess returned 256 exit status
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
  libva info: VA-API version 0.40.0
  libva info: va_getDriverName() returns -1
  libva error: va_getDriverName() failed with unknown libva error,driver_name=(null)
FAIL async/test_clib_luakit / test_website_data
  Timed out while waiting
    interval was 1000msec
    
  Traceback:
  (1) tests/async/test_clib_luakit.lua:104 in function [anonymous]
PASS async/test_clib_luakit / test_register_scheme
PASS async/test_clib_luakit / test_idle_add_del
PASS async/test_clib_luakit / test_invalid_prop
PASS async/test_clib_luakit / test_luakit_index
PASS async/test_clib_luakit / test_luakit
PASS async/test_clib_luakit / test_webkit_version
  openjdk version "1.8.0_144"
  OpenJDK Runtime Environment (IcedTea 3.5.1) (Gentoo icedtea-3.5.1)
  OpenJDK 64-Bit Server VM (build 25.144-b01, mixed mode)
  
  (WebKitPluginProcess:3701): GLib-CRITICAL **: g_source_remove: assertion 'tag > 0' failed
  
  (WebKitPluginProcess:3701): GLib-CRITICAL **: g_source_remove: assertion 'tag > 0' failed
  
  (WebKitPluginProcess:3701): GLib-CRITICAL **: g_io_channel_shutdown: assertion 'channel != NULL' failed
  Failed to shut down debug to appletviewer
PASS async/test_binds_api / test_binds_are_called
PASS async/test_basic / test_about_blank_loads_successfully
Removing temporary directories
Stopping Xvfb
make: *** [Makefile:127: run-tests] Error 1

However, given your track record I'm just going to merge it and you can fix it in a followup.

lluixhi · 2017-09-03T19:08:00Z

Not sure whether that's a compliment or a low blow, but I need to submit an issue upstream about it.

While running tests I would occasionally run into those bugs, and it would also occasionally all pass -- something is flaky about them.

on my end:

>>> Test phase: www-client/luakit-2017.08.10
make -j1 LUA_BIN_NAME=luajit run-tests
cc -fpic -march=native -O2 -pipe -flto=2 -floop-nest-optimize -fuse-linker-plugin -std=gnu99 -W -Wall -Wextra -pthread -I/usr/include/webkitgtk-4.0 -I/usr/include/gtk-3.0 -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/gtk-3.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libdrm -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng16 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -I/usr/include/luajit-2.0 -I/usr/include/webkitgtk-4.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I./  -DVERSION=\"c5328c22\" -shared tests/util.c -Wl,-O1 -Wl,--as-needed  -Wl,--export-dynamic -lgthread-2.0 -pthread -lwebkit2gtk-4.0 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lsoup-2.4 -lgio-2.0 -lgobject-2.0 -lsqlite3 -lluajit-5.1 -ljavascriptcoregtk-4.0 -lglib-2.0 -o tests/util.so
fatal: Not a git repository (or any of the parent directories): .git
Starting Xvfb
PASS style/test_common / test_no_globalconf_in_common
PASS style/test_documentation / test_module_blurb_not_empty
PASS style/test_luacheck / test_luacheck
PASS style/test_source_format / test_vim_modeline
PASS style/test_source_format / test_lua_module_uses_M
PASS style/test_source_format / test_header_comment
PASS style/test_source_format / test_no_trailing_whitespace
PASS style/test_source_format / test_include_guard
PASS style/test_source_format / test_no_tabs_in_indentation
PASS style/test_source_format / test_lua_module_functions_are_documented
PASS style/test_source_format / test_lua_header
PASS style/test_widgets / test_widgets_use_macros
PASS async/test_basic / test_about_blank_loads_successfully
PASS async/test_binds_api / test_binds_are_called
PASS async/test_clib_luakit / test_luakit
PASS async/test_clib_luakit / test_luakit_index
PASS async/test_clib_luakit / test_website_data
PASS async/test_clib_luakit / test_windows_table
PASS async/test_clib_luakit / test_idle_add_del
PASS async/test_clib_luakit / test_webkit_version
PASS async/test_clib_luakit / test_invalid_prop
PASS async/test_clib_luakit / test_register_scheme
PASS async/test_clib_regex / test_regex_matches
PASS async/test_clib_regex / test_regex_with_no_pattern_fails
PASS async/test_clib_regex / test_module
PASS async/test_clib_soup / test_set_accept_policy
PASS async/test_clib_soup / test_set_cookies_storage
PASS async/test_clib_soup / test_soup
PASS async/test_clib_soup / test_set_proxy_uri
PASS async/test_clib_sqlite3 / test_sqlite3_exec
PASS async/test_clib_sqlite3 / test_open_db
PASS async/test_clib_sqlite3 / test_compile_statement
PASS async/test_clib_sqlite3 / test_module
PASS async/test_completion / test_leaving_completion_restores_correct_input_text
PASS async/test_config / test__config_rc_loads_successfully
PASS async/test_http_test_server / test_http_server_returns_file_contents
PASS async/test_image_css / test_image_css
PASS async/test_lib_lousy_uri / test_lousy_uri_properties
PASS async/test_lib_lousy_uri / test_lousy_uri_parse
PASS async/test_lib_lousy_util / test_lousy_util_lua_escape
PASS async/test_lib_lousy_util / test_lousy_util_table_toarray
PASS async/test_lib_lousy_util / test_lousy_util_table_reverse
PASS async/test_lib_lousy_util / test_lousy_util_table_filter_array
PASS async/test_lib_lousy_util / test_lousy_util_table_join
PASS async/test_lib_lousy_util / test_lousy_util_table_copy_clone
PASS async/test_lib_lousy_util / test_lousy_util_table_isclone
PASS async/test_lua_files_load_successfully / test_all_lua_files_load_successfully
PASS async/test_memory_leaks / test_webview_from_closed_tab_is_released
PASS async/test_module_binds_have_descriptions / test_module_binds_have_descriptions
PASS async/test_scroll / test_scrolling_works
PASS async/test_undoclose / test_undo_close_works
PASS async/test_undoclose / test_undo_close_restores_tab_history
PASS async/test_widget / test_widget_of_invalid_type_fails
PASS async/test_widget / test_webview_widget_privacy
PASS async/test_widget / test_bin_widget_set_child
Removing temporary directories
Stopping Xvfb
>>> Completed testing www-client/luakit-2017.08.10

ohhh, part of it might be the name of the C compiler for the test phase. I'll change that in the next pull request.

mgorny · 2017-09-03T19:45:30Z

It was a compliment. Thanks for looking into it.

Closes: gentoo#5228

gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jul 27, 2017

SoapGentoo suggested changes Jul 30, 2017

View reviewed changes

lluixhi force-pushed the luakit branch from 5d5e9b8 to bdd5ee9 Compare July 31, 2017 18:22

lluixhi force-pushed the luakit branch from bdd5ee9 to 2727f1f Compare July 31, 2017 19:21

Hummer12007 reviewed Jul 31, 2017

View reviewed changes

lluixhi force-pushed the luakit branch from 2727f1f to 4a13830 Compare July 31, 2017 20:18

mgorny added the fix on merge There is at least one issue still needing fixing. Please read the comments and fix it while merging. label Aug 3, 2017

mgorny approved these changes Aug 3, 2017

View reviewed changes

mgorny self-assigned this Aug 3, 2017

mgorny removed the fix on merge There is at least one issue still needing fixing. Please read the comments and fix it while merging. label Aug 3, 2017

mgorny removed their assignment Aug 3, 2017

mgorny requested changes Aug 3, 2017

View reviewed changes

lluixhi force-pushed the luakit branch from 4a13830 to 2094986 Compare August 9, 2017 18:37

Hummer12007 reviewed Aug 9, 2017

View reviewed changes

lluixhi force-pushed the luakit branch 3 times, most recently from 5e2ffad to 4794e9d Compare August 10, 2017 20:29

lluixhi force-pushed the luakit branch from cecb4e9 to 0d33a18 Compare August 11, 2017 04:50

mgorny reviewed Aug 11, 2017

View reviewed changes

lluixhi force-pushed the luakit branch 2 times, most recently from 9138ff7 to e9966b1 Compare August 11, 2017 17:53

mgorny requested changes Aug 13, 2017

View reviewed changes

mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Aug 13, 2017

gentoo-repo-qa-bot added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). labels Aug 13, 2017

lluixhi force-pushed the luakit branch from e9966b1 to daa5d2e Compare August 23, 2017 18:21

lluixhi force-pushed the luakit branch from daa5d2e to 3095e08 Compare August 23, 2017 20:48

lluixhi added 4 commits August 25, 2017 11:31

dev-lua/say: add luajit support

752138d

Bump to EAPI 6 Add Test phase. Gentoo-Bug: https://bugs.gentoo.org/628758

dev-lua/luassert: version bump to 1.7.10

10f4075

Bump to EAPI 6 Add Test phase Gentoo-Bug: https://bugs.gentoo.org/628758

dev-lua/luacheck: new package

91f1996

www-client/luakit: new package

617762b

lluixhi force-pushed the luakit branch from 3095e08 to 617762b Compare August 25, 2017 18:35

mgorny approved these changes Sep 2, 2017

View reviewed changes

gentoo-bot closed this in 8011322 Sep 2, 2017

lluixhi deleted the luakit branch September 5, 2017 20:27

strahlc pushed a commit to strahlc/gentoo that referenced this pull request Sep 6, 2017

www-client/luakit: new package

d517808

Closes: gentoo#5228


		inherit toolchain-funcs

		DESCRIPTION="A fast, light, simple to use micro-browser using WebKit and Lua."

www-client/luakit: new package #5228

www-client/luakit: new package #5228

Conversation

lluixhi commented Jul 27, 2017 • edited

Hummer12007 commented Jul 27, 2017

Choose a reason for hiding this comment

lluixhi Jul 31, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lluixhi commented Jul 31, 2017

lluixhi commented Jul 31, 2017 • edited

SoapGentoo commented Jul 31, 2017

Hummer12007 Jul 31, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lluixhi Jul 31, 2017 • edited

Choose a reason for hiding this comment

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgorny left a comment

Choose a reason for hiding this comment

mgorny commented Aug 3, 2017

lluixhi commented Aug 4, 2017 • edited

mgorny commented Aug 6, 2017

lluixhi commented Aug 9, 2017

lluixhi commented Aug 9, 2017 • edited

Hummer12007 Aug 9, 2017 • edited

Choose a reason for hiding this comment

mgorny commented Aug 10, 2017

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lluixhi Aug 11, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Aug 13, 2017

lluixhi commented Aug 23, 2017

mgorny commented Aug 23, 2017

mgorny commented Aug 23, 2017

lluixhi commented Aug 23, 2017

lluixhi commented Aug 25, 2017

gentoo-repo-qa-bot commented Aug 25, 2017

mgorny commented Sep 2, 2017

lluixhi commented Sep 3, 2017 • edited

mgorny commented Sep 3, 2017

lluixhi commented Jul 27, 2017 •

edited

lluixhi Jul 31, 2017 •

edited

lluixhi commented Jul 31, 2017 •

edited

Hummer12007 Jul 31, 2017 •

edited

lluixhi Jul 31, 2017 •

edited

lluixhi commented Aug 4, 2017 •

edited

lluixhi commented Aug 9, 2017 •

edited

Hummer12007 Aug 9, 2017 •

edited

lluixhi Aug 11, 2017 •

edited

lluixhi commented Sep 3, 2017 •

edited