media-gfx/exact-image: Fix building with GCC-6 #5275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: https://bugs.gentoo.org/show_bug.cgi?id=600380 Package-Manager: Portage-2.3.6, Repoman-2.3.2
gentoo-repo-qa-bot
added
the
assigned
|
Pull Request assignment Areas affected: ebuilds media-gfx/exact-image: @gentoo/graphics |
SoapGentoo
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
@Peter-Levine We should always strive for -std= agnostic fixes. If though you run into ODR-related issues at link-time, for the future, just jump to C++11 directly (i.e. append-cxxflags -std=c++11) and be done with it. There's a certain threshold for making things standard agnostic for me, and macro dispatching to avoid ODR failures is imo too much for me. I'll approve but leave it open, if you wish to go pure C++11 instead.
strahlc
pushed a commit
to strahlc/gentoo
that referenced
this pull request
Sep 6, 2017
Closes: https://bugs.gentoo.org/600380 Closes: gentoo#5275 Package-Manager: Portage-2.3.6, Repoman-2.3.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.gentoo.org/show_bug.cgi?id=600380
Package-Manager: Portage-2.3.6, Repoman-2.3.2
This fixes GCC-6 porting issues related to narrowing conversions in brace initialization and invalid implicit conversion from stream object to `bool.
There was also the problem of
static constin-class initialization of non-integral types. This is relaxed for floating-point types with GCC using C++98 but not C++11/14. The dialect-neutral way of handling this is to declare such variables asstatic constin-class in the header but define and initialize them asconstin a relevant source file. All attempts as such failed with ODR violations at link-time. Resorting toconstexprwith conditional dialect-dependent#defines sufficed.Upstream doesn't provide any official means of commit or patch submission. Furthermore, having tested later versions, the GCC-6/GCC-5 related bugs become more egregious (eg., use of
gotos leading to errors of the typeerror: jump to label 'foo' from here crosses initialization of 'bar x').