Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-im/discord v. bump to 0.0.2, added sys-libs/libcxx to RDEPEND #5373

Closed
wants to merge 3 commits into from
Closed

net-im/discord v. bump to 0.0.2, added sys-libs/libcxx to RDEPEND #5373

wants to merge 3 commits into from

Conversation

zyklotomic
Copy link
Contributor

@zyklotomic zyklotomic changed the title v. bump to 0.0.2, added sys-libs/libcxx to RDEPEND net-im/discord v. bump to 0.0.2, added sys-libs/libcxx to RDEPEND Aug 9, 2017
@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Aug 9, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-im/discord-bin

net-im/discord-bin: @johu

@monsieurp
Copy link
Member

@johu ping?

@johu
Copy link
Contributor

johu commented Aug 22, 2017

There are some QA issues:

  • Commit message doesn't follow the standard.
  • Repoman reports following issues on the ebuild:
 ebuild.absdosym               3
   net-im/discord-bin/discord-bin-0.0.2.ebuild: dosym '/opt/${MY_PN}/bin/${MY_PN}'... could use relative path on line: 75
   net-im/discord-bin/discord-bin-0.0.2.ebuild: dosym '/opt/${MY_PN}/share/applications/${MY_PN}.desktop'... could use relative path on line: 76
   net-im/discord-bin/discord-bin-0.0.2.ebuild: dosym '/opt/${MY_PN}/share/pixmaps/${MY_PN}.png'... could use relative path on line: 78
  • Portage reports issues on install phase (after quick fix of repoman warnings):
 * QA Notice: Symbolic link /usr/bin/discord points to /usr/bin/opt/discord/bin/discord which does not exist.
 * QA Notice: Symbolic link /usr/share/applications/discord.desktop points to /usr/share/applications/opt/discord/share/applications/discord.desktop which does not exist.
 * QA Notice: Symbolic link /usr/share/pixmaps/discord.png points to /usr/share/pixmaps/opt/discord/share/pixmaps/discord.png which does not exist.

@Chemrat
Copy link

Chemrat commented Aug 30, 2017

These are warnings from unstable repoman, also to fix them you have to actually change the path, not just delete leading slash, i.e.:

        dosym ../../opt/${MY_PN}/bin/${MY_PN} /usr/bin/${MY_PN}
        dosym ../../../opt/${MY_PN}/share/applications/${MY_PN}.desktop \
                /usr/share/applications/${MY_PN}.desktop
        dosym ../../../opt/${MY_PN}/share/pixmaps/${MY_PN}.png \
                /usr/share/pixmaps/${MY_PN}.png

@johu is it possible for you to make these fixes and accept the PR or it needs fixes from @zyklotomic or a new PR?

@zyklotomic
Copy link
Contributor Author

I'll try to look into it soon. Am busy recently, but will do so soon!

@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/b9a361ebd/output.html#media-sound/snd
https://qa-reports.gentoo.org/output/gentoo-ci/b9a361ebd/output.html#sys-devel/binutils-hppa64

@zyklotomic
Copy link
Contributor Author

@johu ping? I think I fixed the issues that were mentioned.

@johu
Copy link
Contributor

johu commented Sep 4, 2017

Please squash your commits and use the standard commit message format (repoman will help you with that).

@mjeveritt
Copy link
Contributor

@zyklotomic - git rebase should allow you to squash the commits into one .. the final commit should then be performed by "repoman commit" normally, https://devmanual.gentoo.org/ebuild-maintenance/index.html#git-commit-message-format gives you the standard templates! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
6 participants