Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-emulation/sen: Initial commit #5374

Closed
wants to merge 1 commit into from
Closed

Conversation

ntnn
Copy link
Contributor

@ntnn ntnn commented Aug 9, 2017

Package-Manager: Portage-2.3.6, Repoman-2.3.1

Ping at my mentor: @Polynomial-C

@gentoo-repo-qa-bot gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Aug 10, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-emulation/sen

app-emulation/sen: @gentoo/proxy-maint (new package)

<name>Lars Wendler</name>
<description>Proxy maintainer for Nelo</description>
</maintainer>
<upstream>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you want proxy-maint to help here?


EAPI=6

PYTHON_COMPAT=( python3_{4,5} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you test 3.6 as well? If you plan to maintain multiple Python packages, that would be really helpful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.6 currently isn't supported by urwid (and urwidtrees), which are dependencies of app-emulation/sen, hence no 3.6. Once urwid has resolved all issues on 3.6 I wanted to make a new patch set enabling python3_6 for sen and the dependencies.

KEYWORDS="~amd64"
IUSE=""

DEPEND="dev-python/urwid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dependencies on Python modules always require [${PYTHON_USEDEP}] to enforce implementation match.

dev-python/docker-py"
RDEPEND="${DEPEND}"

DOCS="docs/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-array variant of DOCS is generally discouraged, and so is implicit globbing. Also, this implicitly disables installing README* and other defaults. Preferably you'd redefine python_install_all and install extra files there.

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

@ntnn ntnn deleted the app-emulation/sen branch August 11, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants