-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-emulation/sen: Initial commit #5374
Conversation
Pull Request assignment Areas affected: ebuilds app-emulation/sen: @gentoo/proxy-maint (new package) |
<name>Lars Wendler</name> | ||
<description>Proxy maintainer for Nelo</description> | ||
</maintainer> | ||
<upstream> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't you want proxy-maint to help here?
|
||
EAPI=6 | ||
|
||
PYTHON_COMPAT=( python3_{4,5} ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you test 3.6 as well? If you plan to maintain multiple Python packages, that would be really helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.6 currently isn't supported by urwid (and urwidtrees), which are dependencies of app-emulation/sen, hence no 3.6. Once urwid has resolved all issues on 3.6 I wanted to make a new patch set enabling python3_6 for sen and the dependencies.
app-emulation/sen/sen-0.5.1.ebuild
Outdated
KEYWORDS="~amd64" | ||
IUSE="" | ||
|
||
DEPEND="dev-python/urwid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dependencies on Python modules always require [${PYTHON_USEDEP}]
to enforce implementation match.
app-emulation/sen/sen-0.5.1.ebuild
Outdated
dev-python/docker-py" | ||
RDEPEND="${DEPEND}" | ||
|
||
DOCS="docs/*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-array variant of DOCS
is generally discouraged, and so is implicit globbing. Also, this implicitly disables installing README*
and other defaults. Preferably you'd redefine python_install_all
and install extra files there.
Package-Manager: Portage-2.3.6, Repoman-2.3.1
bde1ba6
to
270b641
Compare
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Ping at my mentor: @Polynomial-C