Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

games-simulation/openrct2: version bump to 0.1.1, drop old #5377

Closed
wants to merge 2 commits into from
Closed

games-simulation/openrct2: version bump to 0.1.1, drop old #5377

wants to merge 2 commits into from

Conversation

jansegre
Copy link
Contributor

This follows the live ebuild, now no patches are needed \o/

@lorem-ipsum

@hvraven
Copy link
Contributor

hvraven commented Aug 10, 2017

Cool.
One thing I learned from earlier version bumps of my own: Make it two commits. The first adding the new version and the second dropping the old. This makes it easy to revert the removal in case things go south.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Aug 10, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: games-simulation/openrct2

games-simulation/openrct2: @jansegre, @lorem-ipsum, @gentoo/proxy-maint

mgorny
mgorny requested changes Aug 10, 2017
View reviewed changes
Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split removal and adding the new version into separate commits.

@jansegre
games-simulation/openrct2: version bump to 0.1.1
31a8a53 
Package-Manager: Portage-2.3.6, Repoman-2.3.1
@jansegre
games-simulation/openrct2: drop old
c0d0900 
Package-Manager: Portage-2.3.6, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/fa58523a7/output.html#dev-games/ogre
https://qa-reports.gentoo.org/output/gentoo-ci/fa58523a7/output.html#media-sound/snd
https://qa-reports.gentoo.org/output/gentoo-ci/fa58523a7/output.html#sci-chemistry/icm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgorny mgorny mgorny approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
Milestone
No milestone
4 participants
@jansegre @hvraven @gentoo-repo-qa-bot @mgorny