app-emulation/lxd-2.16: Fix broken SRC_URI #5483
Conversation
My bump to 2.16 had a broken SRC_URI and I didn't notice it because I already had a local "lxd-2.16.tar.gz" distfile. Moreover, this file wasn't even the proper one. This commits fixes the problem, add a missing "zh" locale and removes a spurious patch. Gentoo-Bug: 628334 Package-Manager: Portage-2.3.6, Repoman-2.3.1
gentoo-repo-qa-bot
added
self-maintained
|
Pull Request assignment Areas affected: ebuilds app-emulation/lxd: |
|
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
| LICENSE="Apache-2.0" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64" | ||
|
|
||
| PLOCALES="de el fr it ja nl ru sr sv tr" | ||
| # Portage complains about zh_Hans missing, but repoman doesn't like it when it's there. | ||
| PLOCALES="de el fr it ja nl ru sr sv tr zh" |
There was a problem hiding this comment.
LINGUAS USE flags are deprecated. You should really install those unconditionally, or have some implicit LINGUAS handling (if you really insist). However, I won't delay this fix because of that.
There was a problem hiding this comment.
@mgorny Thanks for the tip. Will do. Do you think that such a change would warrant a r1 version or is it not worth a rebuild? According to https://devmanual.gentoo.org/general-concepts/ebuild-revisions/index.html, I'd say no, but it's not crystal clear in my head.
There was a problem hiding this comment.
I'd say no because:
- You are changing USE flags, so
--changed-usewill trigger the rebuild anyway, and - More importantly — the previous version didn't work so only a few people were able to install it since the fix.
ghost
mentioned this pull request
as per mgorny's suggestion in gentoo#5483 I have tested that, after a merge of that ebuild, localizations still worked (at least the `fr` one). Closes: gentoo#5503 Package-Manager: Portage-2.3.6, Repoman-2.3.1
My bump to 2.16 had a broken SRC_URI and I didn't notice it because I
already had a local "lxd-2.16.tar.gz" distfile. Moreover, this file
wasn't even the proper one.
This commits fixes the problem, add a missing "zh" locale and removes
a spurious patch.
Gentoo-Bug: 628334
Package-Manager: Portage-2.3.6, Repoman-2.3.1