Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable systemd units that create symlinks via the 'Alias' option #5549

Closed
wants to merge 5 commits into from

Conversation

floppym
Copy link
Contributor

@floppym floppym commented Aug 28, 2017

This is needed to keep things working when some packages are rebuilt after upgrading to systemd 234.

@floppym floppym self-assigned this Aug 28, 2017
@floppym
Copy link
Contributor Author

floppym commented Aug 28, 2017

cc @gentoo/kde @gentoo/gnome @gentoo/lxqt @gentoo/systemd

Package-Manager: Portage-2.3.6_p39, Repoman-2.3.3_p17
@EvaSDK
Copy link
Contributor

EvaSDK commented Aug 29, 2017

it sounds to me as it should apply to a lot more than this. Shouldn't apply to any package providing units ? What about user units ?

@floppym
Copy link
Contributor Author

floppym commented Aug 29, 2017

Shouldn't apply to any package providing units ?

Most units are unaffected by the rootprefix change; systemd ignores symlink targets within .wants/ directories.

What about user units ?

Impossible to fix from the package manager.

@EvaSDK
Copy link
Contributor

EvaSDK commented Aug 31, 2017

+1 for merge but I think some kind of announcement must be done to fellow devs so we do not miss this new systemd eclass call when needed. Maybe a QA check in portage like the recently added icon cache update detection.

@floppym
Copy link
Contributor Author

floppym commented Sep 1, 2017

What about user units ?

Actually, user-units are unaffected by the rootprefix change: they still get installed in /usr/lib/systemd/user since they are not "boot-critical". So nothing to really worry about there.

@mgorny
Copy link
Member

mgorny commented Sep 1, 2017

I think it'd be nice to actually explain there when it needs to be used and when not.

@floppym
Copy link
Contributor Author

floppym commented Sep 2, 2017

I added a paragraph explaining intended use of the systemd_reenable function.

@floppym floppym changed the title Reenable systemd units that create symlinks via Also= Reenable systemd units that create symlinks via the 'Alias' option Sep 2, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/b277e46e1/output.html#media-sound/snd
https://qa-reports.gentoo.org/output/gentoo-ci/b277e46e1/output.html#sys-devel/binutils-hppa64

@floppym
Copy link
Contributor Author

floppym commented Sep 3, 2017

Rebased and merged.

@floppym floppym closed this Sep 3, 2017
@floppym floppym deleted the systemd-reenable branch December 9, 2017 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants