Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-misc/sstp-client: Version bump to 2.0.11 #5618

Closed
wants to merge 1 commit into from

Conversation

mjeveritt
Copy link
Contributor

Package-Manager: Portage-2.3.6, Repoman-2.3.1

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 5, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-misc/sstp-client

net-misc/sstp-client: @mjeveritt, @maksbotan, @gentoo/proxy-maint

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 * ERROR: net-misc/sstp-client-1.0.11::gentoo failed (test phase):
 *   Make check failed. See above for details.
FAIL: utest_route
=================

Could not get route
FAIL utest_route (exit status: 1)

@mjeveritt
Copy link
Contributor Author

mjeveritt commented Oct 18, 2017

@mgorny : Emerge.log and build.log please. Tia.

@mgorny
Copy link
Member

mgorny commented Oct 18, 2017

Enable FEATURES=network-sandbox test and see for yourself. Ofc, you should've done that in the first place.

@mjeveritt
Copy link
Contributor Author

@mgorny : funny that, it worked with FEATURES="test".

Perhaps you can point me to the policy document which details what tests a maintainer should be running for his packages ... I appear to have missed it. Either that, or my testing environment is lacking some setting ..
As a QA representative, this should be quite a trivial request ...

@mgorny
Copy link
Member

mgorny commented Oct 18, 2017

https://devmanual.gentoo.org/ebuild-writing/functions/src_test/index.html

The big section on network access.

Also, please cut your snarky comments. They are not welcome here, or anywhere else in Gentoo, and you have been warned multiple times.

@mjeveritt
Copy link
Contributor Author

Also, please cut your snarky comments. They are not welcome here, or anywhere else in Gentoo, and you have been warned multiple times.

Funny that .. seems to be par for the course for anyone with an @ .. yourself especially. Perhaps leading a good example might get you a bit further than your normal bullying tactics. Besides, what you gonna do anyway, ComRel me, or just ban me from Github .. and what's that gonna achieve? Nadda, yes.

Package-Manager: Portage-2.3.6, Repoman-2.3.1
@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

@gentoo-bot gentoo-bot closed this in 129c10c Feb 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
3 participants