Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tmuxp - a python session manager built on libtmux #5631

Closed
wants to merge 3 commits into from

Conversation

mjeveritt
Copy link
Contributor

No description provided.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Sep 6, 2017
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-python/kaptan, dev-python/libtmux, dev-python/tmuxp

dev-python/kaptan: @gentoo/proxy-maint (new package)
dev-python/libtmux: @gentoo/proxy-maint (new package)
dev-python/tmuxp: @gentoo/proxy-maint (new package)

@mjeveritt
Copy link
Contributor Author

mjeveritt commented Sep 6, 2017

Reminder to self:

  • Check python versions, drop pypy
  • Drop PYTHON_DEPS (inc.by distutils-r1)
    Thanks floppym !

@monsieurp
Copy link
Member

@mjeveritt hi! what's left to do? can we merge this PR as-is?


inherit distutils-r1

DESCRIPTION="Configuration manager in your pocket"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Configuration manager in your pocket" could be anything. Could you elaborate on this DESCRIPTION, please?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll blame that on the shitty github description..... 😀

Perhaps something more fitting would be "Multiple config format parser" but that's verging on gibberish too .. ideas?! 😧

<email>proxy-maint@gentoo.org</email>
<name>Proxy Maintainers</name>
</maintainer>
</pkgmetadata>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

longdescription is missing, you can add the github upstream here too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this look better:
https://bpaste.net/show/2cc3dd0d0b68

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better, but I am not sure about the word "syntaxes"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended further, how's this:
https://bpaste.net/show/8cac80fca726

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

Michael Everitt added 3 commits November 5, 2017 13:36
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Package-Manager: Portage-2.3.6, Repoman-2.3.1
@mike-kfed
Copy link

What's the status on this one? Looks like all QA issues are fixed, I'd love to see that in the main tree as tmuxp is a useful tool and not easily installed using pip.

@monsieurp
Copy link
Member

monsieurp commented Nov 30, 2017

@mike-kfed Hi? What's up buddy? Have we met? Can you please try not to boss us around please?

Here's some basic rules to interact with strangers on the Internet, especially strangers you need something from:

  1. Introduce yourself.
  2. Say hi.
  3. Be polite.
  4. Be patient.

@monsieurp
Copy link
Member

Looking forward to our next digital encounter.

@mike-kfed
Copy link

Sorry if that came across bossy, I just wanted to know what's missing and show interest as I may be able to help.

@monsieurp
Copy link
Member

No harm done. We've been a bit overwhelmed with PRs lately but this one is in the queue, don't worry. We'll get to it eventually. Please bear with us. 🕐

LICENSE="BSD"

SLOT="0"
KEYWORDS="~amd64 ~x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocks are broken:

DESCRIPTION
HOMEPAGE
SRC_URI
<free line>
LICENSE
SLOT
KEYWORDS

SLOT="0"
KEYWORDS="~amd64 ~x86"

DEPEND="${PYTHON_DEPS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distutils-r1 doesnt need ${PYTHON_DEPS} by default

SLOT="0"
KEYWORDS="~amd64 ~x86"

DEPEND="${PYTHON_DEPS}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

LICENSE="BSD"

SLOT="0"
KEYWORDS="~amd64 ~x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix blocks

SLOT="0"
KEYWORDS="~amd64 ~x86"

DEPEND="${PYTHON_DEPS}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

HOMEPAGE="https://kaptan.readthedocs.io/"

SRC_URI="https://github.com/emre/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz
mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just use the pypi mirror, as that is usually the properly prepared tarball and not some autogenerated git archive thingie

@mjeveritt
Copy link
Contributor Author

Thanks for the reviews, guys. I think some of these are pending, but not pushed up here yet. Expect some update in the next couple of days.

@monsieurp
Copy link
Member

@mjeveritt ping? :)

@monsieurp
Copy link
Member

@mjeveritt ping? :(

@mgorny
Copy link
Member

mgorny commented Mar 3, 2018

Closing given no activity.

@mgorny mgorny closed this Mar 3, 2018
@mjeveritt
Copy link
Contributor Author

kaptan added in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fb50753df60fea7b845f309ff4147912b9fd8d6 . Will likely revisit, if not already merged.

@mjeveritt
Copy link
Contributor Author

Fixed in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2c50cb29e61200875643accdca7a0ddf599c8b7 thanks @chutz 😃 👍
I can delete my local branch!

@mjeveritt mjeveritt deleted the tmuxp branch May 12, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
7 participants