New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tmuxp - a python session manager built on libtmux #5631
Conversation
Pull Request assignment Areas affected: ebuilds dev-python/kaptan: @gentoo/proxy-maint (new package) |
Reminder to self:
|
@mjeveritt hi! what's left to do? can we merge this PR as-is? |
|
||
inherit distutils-r1 | ||
|
||
DESCRIPTION="Configuration manager in your pocket" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Configuration manager in your pocket" could be anything. Could you elaborate on this DESCRIPTION, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll blame that on the shitty github description..... 😀
Perhaps something more fitting would be "Multiple config format parser" but that's verging on gibberish too .. ideas?! 😧
<email>proxy-maint@gentoo.org</email> | ||
<name>Proxy Maintainers</name> | ||
</maintainer> | ||
</pkgmetadata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
longdescription is missing, you can add the github upstream here too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this look better:
https://bpaste.net/show/2cc3dd0d0b68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better, but I am not sure about the word "syntaxes"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't sound right, I agree .. but it checks out .. https://www.thefreedictionary.com/syntaxes , https://simple.wiktionary.org/wiki/syntax , http://www.memidex.com/syntaxes etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amended further, how's this:
https://bpaste.net/show/8cac80fca726
👍 All QA issues have been fixed! |
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Package-Manager: Portage-2.3.6, Repoman-2.3.1
Package-Manager: Portage-2.3.6, Repoman-2.3.1
What's the status on this one? Looks like all QA issues are fixed, I'd love to see that in the main tree as tmuxp is a useful tool and not easily installed using pip. |
@mike-kfed Hi? What's up buddy? Have we met? Can you please try not to boss us around please? Here's some basic rules to interact with strangers on the Internet, especially strangers you need something from:
|
Looking forward to our next digital encounter. |
Sorry if that came across bossy, I just wanted to know what's missing and show interest as I may be able to help. |
No harm done. We've been a bit overwhelmed with PRs lately but this one is in the queue, don't worry. We'll get to it eventually. Please bear with us. 🕐 |
LICENSE="BSD" | ||
|
||
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocks are broken:
DESCRIPTION
HOMEPAGE
SRC_URI
<free line>
LICENSE
SLOT
KEYWORDS
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" | ||
|
||
DEPEND="${PYTHON_DEPS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
distutils-r1
doesnt need ${PYTHON_DEPS}
by default
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" | ||
|
||
DEPEND="${PYTHON_DEPS}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
LICENSE="BSD" | ||
|
||
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix blocks
SLOT="0" | ||
KEYWORDS="~amd64 ~x86" | ||
|
||
DEPEND="${PYTHON_DEPS} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
HOMEPAGE="https://kaptan.readthedocs.io/" | ||
|
||
SRC_URI="https://github.com/emre/${PN}/archive/v${PV}.tar.gz -> ${P}.tar.gz | ||
mirror://pypi/${PN:0:1}/${PN}/${P}.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just use the pypi mirror, as that is usually the properly prepared tarball and not some autogenerated git archive thingie
Thanks for the reviews, guys. I think some of these are pending, but not pushed up here yet. Expect some update in the next couple of days. |
@mjeveritt ping? :) |
@mjeveritt ping? :( |
Closing given no activity. |
kaptan added in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2fb50753df60fea7b845f309ff4147912b9fd8d6 . Will likely revisit, if not already merged. |
Fixed in https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e2c50cb29e61200875643accdca7a0ddf599c8b7 thanks @chutz 😃 👍 |
No description provided.