dev-util/vint: verbump to 0.3.14 and related changes #5708
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gentoo-repo-qa-bot
added
new package
|
Rebased and updated PR to resolve merge conflicts. |
This module is shipped with >=dev-lang/python-3.5. dev-python/typing provides a backport for Pythons that don't have it. KEYWORDS are intersection of dev-python/typing and dev-lang/python. Closes: https://bugs.gentoo.org/628378 Package-Manager: Portage-2.3.8, Repoman-2.3.3
Closes: https://bugs.gentoo.org/628380 Package-Manager: Portage-2.3.8, Repoman-2.3.3
|
👍 All QA issues have been fixed! |
monsieurp
suggested changes
Sep 23, 2017
|
|
||
| EAPI=6 | ||
|
|
||
| PYTHON_COMPAT=( python{2_7,3_4,3_5,3_6} pypy{,3} ) |
There was a problem hiding this comment.
Correct me if I'm wrong but since the typing module is shipped with Python 3.5 and 3.6, these versions shouldn't be listed here, should they?
There was a problem hiding this comment.
They should. This allows a package, which supports e.g. python2.7 and python3.5, depend on virtual-typing. Otherwise it would be necessary to create a conditional dep for pythons < 3.5, which defies the purpose of this virtual. Check out virtual/python-enum34.
There was a problem hiding this comment.
@monsieurp, ping. Please re-review.
monsieurp
approved these changes
Sep 29, 2017
|
Thank you, @monsieurp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add virtual/python-typing similarly to how we have virtual/python-enum34, etc. packages.
vint-0.3.14 requires the typing Python module and virtual/python-typing makes dependencies easy.