EFL, enlightenment and terminology version bump #5832

bjacquin · 2017-10-01T17:24:46Z

Hi,

This request is to version bump EFL, enlightenment and terminology as per https://bugs.gentoo.org/show_bug.cgi?id=631580 and https://bugs.gentoo.org/show_bug.cgi?id=631578

a17r · 2017-10-01T17:44:48Z

Thanks, there is already a similar PR: #5819

To avoid duplicating work, please check if you add anything in addition to that PR.

bjacquin · 2017-10-02T21:44:06Z

Thanks for this, I made some comment in the mentioned PR

nemunaire · 2017-10-03T05:22:48Z

I closed my PR in favour of this one.

bjacquin · 2017-10-09T21:53:52Z

New proposal including @nemunaire changes for terminology

Gentoo-Bug: #631956

monsieurp · 2017-12-21T21:23:48Z

@bjacquin could you please regenerate Manifest files? I'll merge this PR afterwards.

bjacquin · 2018-01-15T02:46:56Z

Manifest update done as long as new version bump

mgorny · 2018-03-03T15:21:19Z

x11-wm/enlightenment/metadata.xml

+<maintainer type="person">
+	<email>bertrand@jacquin.bzh</email>
+	<name>Bertrand Jacquin</name>
+</maintainer>


You didn't add proxy-maint team, so we can't merge this. Also, it's a good idea to split maintainer change into a separate commit.

mgorny

I'm sorry to say but this is a huge piece of software that has been neglected for years, so you've got a hard task ahead of you. Please note that some comments from the first changeset may apply to subsequent files.

mgorny · 2018-03-03T18:07:14Z

x11-terms/terminology/terminology-1.0.0.ebuild

@@ -1,4 +1,4 @@
-# Copyright 1999-2017 Gentoo Foundation


The Gentoo-Bug commit tag is obsolete. Please use either Bug or Closes (with full URL), depending on whether you wish to close a bug or just leave a comment.

mgorny · 2018-03-03T18:08:18Z

dev-libs/efl/Manifest

@@ -1,2 +1,3 @@
 DIST efl-1.17.0.tar.xz 43485360 BLAKE2B 97a79bda40658eac6e50886a01821bb8c98d6f56d18fcd51dc3827154506064bec3bf665c8f471919aedb03ae83ce4045293afa9a0bf8d3eaf947221ef7cba9e SHA512 e4f28f938daf4ec1cb3d761407a443e401b59c6bb0f9fa6cd771dbd256b95f4a32a5f9e6bd8ad8328708a382f732e67abd1a23c7be2ff222f08bc8135a2435da


Please shorten the commit message to only roughly describe changes. There is really no need or reason to make it into a detailed changelog, and it is going to occupy a lot of screen space for anyone looking at the log.

mgorny · 2018-03-03T18:09:46Z

dev-libs/efl/efl-1.20.7.ebuild

+DESCRIPTION="Enlightenment Foundation Libraries all-in-one package"
+
+LICENSE="BSD-2 GPL-2 LGPL-2.1 ZLIB"
+IUSE="avahi +bmp debug connman drm +eet egl examples fbcon +fontconfig fribidi gif gles glib gnutls gstreamer harfbuzz hyphen +ico ibus jpeg2k libressl neon oldlua opengl ssl pdf physics pixman +png postscript +ppm +psd pulseaudio raw scim sdl sound svg systemd tga tiff tslib unwind v4l valgrind vlc vnc wayland webp X xcf xim xine xpm"


Please wrap overlong lists, with special exception for KEYWORDS that should not be wrapped not to break ekeyword tool.

mgorny · 2018-03-03T18:10:12Z

dev-libs/efl/efl-1.20.7.ebuild

+IUSE="avahi +bmp debug connman drm +eet egl examples fbcon +fontconfig fribidi gif gles glib gnutls gstreamer harfbuzz hyphen +ico ibus jpeg2k libressl neon oldlua opengl ssl pdf physics pixman +png postscript +ppm +psd pulseaudio raw scim sdl sound svg systemd tga tiff tslib unwind v4l valgrind vlc vnc wayland webp X xcf xim xine xpm"
+
+REQUIRED_USE="
+	pulseaudio?	( sound )


Please don't align. This is highly dependant on tab size and turns it into a mess. Also, sort lexically unless you need to explicitly express preference between two options.

Also, it seems that some of those constraints are circular, so it might be reasonable to eventually look into cleaning them up. However, this is not strictly necessary right now.

mgorny · 2018-03-03T18:10:30Z

dev-libs/efl/efl-1.20.7.ebuild

+	opengl?		( || ( X sdl wayland ) )
+	gles?		( || ( X wayland ) )
+	gles?		( !sdl )
+	gles?		( egl )


Merge all the gles?-es into one.

mgorny · 2018-03-03T18:45:32Z

dev-python/python-efl/python-efl-1.20.0.ebuild

+		media-gfx/graphviz[python]
+		dev-python/sphinx[${PYTHON_USEDEP}]
+	)
+	doc? ( >dev-python/sphinx-1.0[${PYTHON_USEDEP}] )"


Why two doc? blocks (also with duplicate dep on sphinx).

Agreed, dropped

mgorny · 2018-03-03T18:47:07Z

dev-python/python-efl/python-efl-1.20.0.ebuild

+	dev-python/setuptools[${PYTHON_USEDEP}]
+	>=dev-python/cython-0.21[${PYTHON_USEDEP}]
+	doc? (
+		media-gfx/graphviz[python]


If you dep on [python], then you also need to use-dep on it. Please verify if that's really the case and if it is, then you'd either have to lower the ebuild to just py2.7 or use any-of API of python-r1 (which is harder).

Indeed, [python] is not needed, dropping it

mgorny · 2018-03-03T18:47:53Z

dev-python/python-efl/python-efl-1.20.0.ebuild

+
+python_install_all() {
+	use doc && DOCS=( "${S}"/build/doc/html )
+	use examples && EXAMPLES=( examples/. )


This is banned in EAPI 6.

What exactly is banned in EAPI 6 in this context ?

EXAMPLES variable.

mgorny · 2018-03-03T18:48:01Z

dev-python/python-efl/python-efl-1.20.0.ebuild

+}
+
+python_install_all() {
+	use doc && DOCS=( "${S}"/build/doc/html )


Why the absolute path?

No reason, this was in place before, changing this.

mgorny · 2018-03-03T18:48:20Z

dev-libs/efl/metadata.xml

+	<email>proxy-maint@gentoo.org</email>
+	<name>Proxy Maintainers</name>
+</maintainer>
+<maintainer type="person">


Reverse the order, proxy-maint always goes last.

ff2000 · 2018-03-25T09:45:24Z

How is this PR/Review going? Is the last remaining issue the broken eclass? Is it really necessary for this PR to get merged?
Because at least the 0.21.7 ebuild is broken and it is way behind upstream. It looks like Bertrand did a great job, would be nice to see it merged!

mgorny · 2018-03-25T10:34:06Z

Ok, I'll merge it now and we'll continue later on. Few minor notes (I'll fix them for you):

please mention the new version in commit message summary,
adding you as co-maint doesn't really close the bug of enlightenment team being non-existing.

Closes: https://bugs.gentoo.org/631956

Add missing USE flags. Adjust dependency atoms. Adjust REQUIRED_USE. Call gnome2_icon_cache_update in order to update icon cache Call xdg_mimeinfo_database_update in order to update xdg cache Closes: https://bugs.gentoo.org/618400 Closes: https://bugs.gentoo.org/648828 Package-Manager: Portage-2.3.8, Repoman-2.3.1

Closes: https://bugs.gentoo.org/631578 Package-Manager: Portage-2.3.8, Repoman-2.3.1

Closes: https://bugs.gentoo.org/631580 Package-Manager: Portage-2.3.8, Repoman-2.3.1

Move to git-r3 Move URL to https Package-Manager: Portage-2.3.8, Repoman-2.3.1

Package-Manager: Portage-2.3.19, Repoman-2.3.6

Closes: gentoo#5832 Package-Manager: Portage-2.3.19, Repoman-2.3.6

mgorny · 2018-03-25T11:18:12Z

@bjacquin, I've force-pushed commits updated for merge to your branch. Please fetch and git reset --hard to my code before you start working again.

I can't merge this since it fails for me straight away:

configure: error: Full OpenGL with EGL is not supported, please add --with-opengl=es to your configure options to switch to EGL + OpenGL ES.

!!! Please attach the following file when seeking support:
!!! /tmp/portage/dev-libs/efl-1.20.7/work/efl-1.20.7/config.log

gentoo-repo-qa-bot · 2018-03-25T14:03:58Z

Pull request CI report

Report generated at: 2018-03-25 14:03 UTC
Newest commit scanned: 3f6726e
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/af93872b7/output.html#net-fs/samba

gentoo-repo-qa-bot · 2018-04-16T15:50:08Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-libs/efl, dev-python/python-efl, x11-terms/terminology, x11-wm/enlightenment

dev-libs/efl: @gentoo/proxy-maint (maintainer needed)
dev-python/python-efl: @gentoo/proxy-maint (maintainer needed)
x11-terms/terminology: @gentoo/proxy-maint (maintainer needed)
x11-wm/enlightenment: @gentoo/proxy-maint (maintainer needed)

WARNING: The following maintainers do not match any Bugzilla accounts:

enlightenment@gentoo.org

Bugs linked: 618400, 648828, 631578, 631956, 631580

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Gentoo Mirror & CI services are provided by Michał Górny. The hardware was kindly provided by Todd Goodman. This unofficial service is not associated with Gentoo Infrastructure or Gentoo Foundation.

This service is provided by the service provider "as is" and any express or implied warranties, including, but not limited to, the implied warranties of merchantability and fitness for a particular purpose are disclaimed. In no event shall the service provider be liable for any direct, indirect, incidental, special, exemplary, or consequential damages (including, but not limited to, procurement of substitute goods or services; loss of use, data, or profits; or business interruption) however caused and on any theory of liability, whether in contract, strict liability, or tort (including negligence or otherwise) arising in any way out of the use of this service, even if advised of the possibility of such damage.

FuzzyGophers · 2018-05-20T02:21:58Z

ping

FuzzyGophers · 2018-05-20T02:35:27Z

disregard. both bugs referenced are fixed. If this PR addresses anything outside of those bugs then please re-open.

bjacquin · 2018-06-26T22:50:41Z

Since most of the change were actually merged, not including original author and including load of unrelated stuff, I am not sure this is worth to keep this ticket open anymore. I will contribute via new PR.

gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Oct 1, 2017

bjacquin force-pushed the dev/beber/e-bump branch from cfd7b1c to 5ae31a5 Compare October 2, 2017 21:44

bjacquin force-pushed the dev/beber/e-bump branch from 5ae31a5 to 57cf191 Compare October 9, 2017 21:53

bjacquin referenced this pull request Oct 9, 2017

x11-terms/terminology: requires X USE flag in dev-libs/efl

70f1ce6

Gentoo-Bug: #631956

bjacquin force-pushed the dev/beber/e-bump branch from 57cf191 to f742194 Compare October 9, 2017 22:00

bjacquin mentioned this pull request Oct 9, 2017

Fixed efl configure options #4407

Closed

bjacquin force-pushed the dev/beber/e-bump branch from f742194 to 0054b75 Compare October 9, 2017 22:50

mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Nov 4, 2017

gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 4, 2017

bjacquin force-pushed the dev/beber/e-bump branch from 0054b75 to 24beafd Compare January 15, 2018 02:46

bjacquin force-pushed the dev/beber/e-bump branch from 24beafd to a55aacb Compare March 3, 2018 15:00

mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Mar 3, 2018

mgorny reviewed Mar 3, 2018

View reviewed changes

gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. and removed no bug found No Bug/Closes found in the commits. labels Mar 3, 2018

bjacquin force-pushed the dev/beber/e-bump branch from a55aacb to a3eea53 Compare March 3, 2018 16:35

mgorny requested changes Mar 3, 2018

View reviewed changes

bjacquin force-pushed the dev/beber/e-bump branch 3 times, most recently from 96735fe to 5cf2e81 Compare March 4, 2018 00:02

nemunaire and others added 9 commits March 25, 2018 12:38

x11-terms/terminology: Requires X USE flag in dev-libs/efl

53615b3

Closes: https://bugs.gentoo.org/631956

x11-wm/enlightenment: Version bump to 0.21.11

8f30ca3

Closes: https://bugs.gentoo.org/631578 Package-Manager: Portage-2.3.8, Repoman-2.3.1

x11-terms/terminology: Version bump to 1.1.1

f12da6b

Closes: https://bugs.gentoo.org/631580 Package-Manager: Portage-2.3.8, Repoman-2.3.1

dev-python/python-efl: Version bump to 1.20.0

05b413b

Move to git-r3 Move URL to https Package-Manager: Portage-2.3.8, Repoman-2.3.1

dev-libs/efl: Add proxy-maint and myself as maintainer

3289df5

Package-Manager: Portage-2.3.19, Repoman-2.3.6

x11-wm/enlightenment: Add proxy-maint and myself as maintainer

38f85a9

Package-Manager: Portage-2.3.19, Repoman-2.3.6

x11-terms/terminology: Add proxy-maint and myself as maintainer

a3b15f5

Package-Manager: Portage-2.3.19, Repoman-2.3.6

dev-python/python-efl: Add proxy-maint and myself as maintainer

3f6726e

Closes: gentoo#5832 Package-Manager: Portage-2.3.19, Repoman-2.3.6

mgorny force-pushed the dev/beber/e-bump branch from 5cf2e81 to 3f6726e Compare March 25, 2018 11:07

mgorny removed the assigned PR successfully assigned to the package maintainer(s). label Apr 16, 2018

FuzzyGophers closed this May 20, 2018

bjacquin deleted the dev/beber/e-bump branch June 26, 2018 22:50

		@@ -1,2 +1,3 @@
		DIST efl-1.17.0.tar.xz 43485360 BLAKE2B 97a79bda40658eac6e50886a01821bb8c98d6f56d18fcd51dc3827154506064bec3bf665c8f471919aedb03ae83ce4045293afa9a0bf8d3eaf947221ef7cba9e SHA512 e4f28f938daf4ec1cb3d761407a443e401b59c6bb0f9fa6cd771dbd256b95f4a32a5f9e6bd8ad8328708a382f732e67abd1a23c7be2ff222f08bc8135a2435da

EFL, enlightenment and terminology version bump #5832

EFL, enlightenment and terminology version bump #5832

Conversation

bjacquin commented Oct 1, 2017

a17r commented Oct 1, 2017

bjacquin commented Oct 2, 2017

nemunaire commented Oct 3, 2017

bjacquin commented Oct 9, 2017

monsieurp commented Dec 21, 2017

bjacquin commented Jan 15, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ff2000 commented Mar 25, 2018

mgorny commented Mar 25, 2018

mgorny commented Mar 25, 2018

gentoo-repo-qa-bot commented Mar 25, 2018

gentoo-repo-qa-bot commented Apr 16, 2018

FuzzyGophers commented May 20, 2018

FuzzyGophers commented May 20, 2018

bjacquin commented Jun 26, 2018