app-vim/jedi: Enabled tests

[TheChymera]

Ebuild improvement (not needing revbump):

• .tar.gz is prefferable to .zip.
• Tests actually work, so we enable them.

The tests are a bit quirky, though. They are run my the make script of the package, and if we attempt to run them again via the ebuild phase they fail all over the place (they are somehow trying to pull in deps).

Also the tests are only pthon3 compatible, but they fail not contingent on the python USE flags, but ontingent on the first python selected via eselect :-/

@monsieurp

Package-Manager: Portage-2.3.13, Repoman-2.3.3

[gentoo-repo-qa-bot]

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-vim/jedi

app-vim/jedi: horea.christ[at]gmail.com, @gentoo/proxy-maint, @gentoo/vim

[monsieurp]

If tests only work with Python 3, please make sure to check that the Python implementation the user has chosen on his system in indeed Python 3. @mgorny wrote a function to perform this check called python_is_python3. You need to add it to the if clause:

if use test && python_is_python3; then
    default;
else
    :;
fi

Also, can we move this code to the src_test phase? It would be more appropriate to run tests during this phase.

[floppym]

This ebuild isn't using python-r1.eclass properly at all. I do not see any calls to python_foreach_impl.

[floppym]

I suggest converting to python-single-r1.

[floppym]

Or, if python is only used at build time, python-any-r1 should be used.

If python is only used for tests, having python2_7 in PYTHON_COMPAT makes no sense.

[monsieurp]

I'm digging further into this and it turns out test files are fetched from Github:

$ cat conftest.py
import urllib.request
...
VSPEC_URL = 'https://github.com/kana/vim-vspec/archive/1.4.1.zip'
...
def pytest_configure(config):
    if not os.path.isdir(CACHE_FOLDER):
        os.mkdir(CACHE_FOLDER)

    if not os.path.exists(VSPEC_FOLDER):
        name, hdrs = urllib.request.urlretrieve(VSPEC_URL)
...

This is clearly not OK. We've got to patch conftest.py so that it doesn't fetch the zip file and let Portage take care of this part.

@TheChymera do you want to do it?

[TheChymera]

@monsieurp I currently don't have the time to further dig into this. I made the PR mainly to share the level I understood this atm and provide a reference for when I might get back to it. If you can patch this it would be really nice :)

[monsieurp]

OK fine. Let me close this PR. I'm going to file a bug and link to here then.