Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

app-editors/scite: Tidy ebuild #6190

Closed
wants to merge 1 commit into from
Closed

app-editors/scite: Tidy ebuild #6190

wants to merge 1 commit into from

Conversation

cjmayo
Copy link
Contributor

@cjmayo cjmayo commented Nov 14, 2017

  • eutils.eclass not needed
  • one sed not two for gtk/makefile
  • consistent sed paths and error messages
  • Encoding now removed from desktop file
  • ensure variable declared in src_compile is local
  • dodir's in src_install not needed

Package-Manager: Portage-2.3.13, Repoman-2.3.3

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: app-editors/scite

app-editors/scite: ervin.peters[at]ervnet.de, @gentoo/proxy-maint

No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message.

If there is no bug open for this pull request, please open one. Otherwise, please link it to the commit messages as noted above.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 14, 2017
@a17r
Copy link
Member

a17r commented Nov 14, 2017

@jonasstein seems you touched the ebuild last time

@jonasstein
Copy link
Contributor

jonasstein commented Nov 14, 2017 •
edited

Thank you for the tidy up. I can not review it before weekend but it looks good on first glance. Ervin, you can test it in the meantime and report if there is any objection from your point of position. @cjmayo do you want to join as second proxied maintainer for this package too?
Could you change the last line in the comment to
Closes: https://bugs.gentoo.org/637518
Then we do not forget it later. Thank you.
Update: got reply from Erwin. I will take care on the requests around scite on the weekend.

@jonasstein jonasstein self-assigned this Nov 14, 2017
@cjmayo
app-editors/scite: Tidy ebuild
f1d264a 
- eutils.eclass not needed
- one sed not two for gtk/makefile
- consistent sed paths and error messages
- Encoding now removed from desktop file
- ensure variable declared in src_compile is local
- dodir's in src_install not needed

Package-Manager: Portage-2.3.13, Repoman-2.3.3

Closes: https://bugs.gentoo.org/637518
@cjmayo
Copy link
Contributor Author

cjmayo commented Nov 16, 2017

Changed tag to Closes.

As to proxying, I am maintaining my own fork of the ebuild at the moment for a couple of reasons:

  • Better icons, 3.7 patch at:
    https://sourceforge.net/p/scintilla/feature-requests/1170/#579c/8744/d145/3e8f
    Maybe that could be added behind a USE flag If it could be hosted somewhere

  • Patches for my own preferences, which are relative to ${WORKDIR}/scite and not ${WORKDIR} so the cd before eapply_user doesn't work for me. And I don't want to have to manually edit the paths - they are made from a clone of the scintilla-scite repository.

@jonasstein
Copy link
Contributor

merged in commit 0d0a3c4
Thank you.

@jonasstein jonasstein closed this Nov 17, 2017
@cjmayo cjmayo deleted the scite-tidy branch November 29, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jonasstein jonasstein

Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@cjmayo @gentoo-repo-qa-bot @a17r @jonasstein