x11-themes/silver-xcursors: use readme.gentoo-r1.eclass and EAPI=6 (bug #637686) #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request assignment Areas affected: ebuilds x11-themes/silver-xcursors: @gentoo/desktop-misc Bugs linked: 637686 |
gentoo-repo-qa-bot
added
assigned
ghost
changed the title
|
@floppym suggested me to use the |
SoapGentoo
suggested changes
Nov 17, 2017
| cp -R "${WORKDIR}"/${MY_P:5}/Silver/cursors "${D}"/usr/share/cursors/xorg-x11/Silver/ || die | ||
| dodoc "${WORKDIR}"/${MY_P:5}/README | ||
| dodir /usr/share/cursors/xorg-x11/Silver/cursors | ||
| cp -R "${S}/Silver/cursors" "${D}/usr/share/cursors/xorg-x11/Silver" || die |
There was a problem hiding this comment.
remove these two lines and try:
insinto /usr/share/cursors/xorg-x11/Silver/
doins -r Silver/cursors
| dodoc "${WORKDIR}"/${MY_P:5}/README | ||
| dodir /usr/share/cursors/xorg-x11/Silver/cursors | ||
| cp -R "${S}/Silver/cursors" "${D}/usr/share/cursors/xorg-x11/Silver" || die | ||
| dodoc "${S}/README" |
There was a problem hiding this comment.
try einstalldocs (and see whether it doesn't install additional junk)
|
Sorry for the big delay. I just fixed this ebuild as you suggested. Is it OK now? |
|
I removed the DOCS array due to @monsieurp's suggestion. |
monsieurp
approved these changes
Jan 26, 2018
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elog should be used instead of einfo for important messages that should
be read by users; moreover elog is logged by default while einfo isn't
https://dev.gentoo.org/~zmedico/portage/doc/portage.html#package-ebuild-helper-functions-output
Closes: https://bugs.gentoo.org/637686