Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-util/yuicompressor: adding package #622

Merged
merged 2 commits into from Jan 13, 2016

Conversation

hydrapolic
Copy link
Contributor

Package-Manager: portage-2.2.26
@monsieurp
Copy link
Member

@gentoo/proxy-maint

@monsieurp monsieurp added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). labels Jan 8, 2016
@monsieurp
Copy link
Member

This ebuild contains two bundled jars:

Preparing source in /var/tmp/portage/dev-util/yuicompressor-2.4.8/work ...
Searching for bundled jars:
/var/tmp/portage/dev-util/yuicompressor-2.4.8/work/yuicompressor-2.4.8/lib/rhino-1.7R2.jar
/var/tmp/portage/dev-util/yuicompressor-2.4.8/work/yuicompressor-2.4.8/lib/jargs-1.0.jar

@hydrapolic
Copy link
Contributor Author

@monsieurp does not work with the latest rhino that is in portage :-(

Do we close the PR as invalid and wait until they bundle a current version of the libs?

@monsieurp
Copy link
Member

Of course.

https://github.com/yui/yuicompressor#modified-rhino-files

YUI Compressor uses a modified version of the Rhino library (http://www.mozilla.org/rhino/) The changes were made to support JScript conditional comments, preserved comments, unescaped slash characters in regular expressions, and to allow for the optimization of escaped quotes in string literals.

@hydrapolic
Copy link
Contributor Author

@monsieurp, well that explains it. I overlooked this.

@monsieurp
Copy link
Member

To be fair, I'm not comfortable adding this package to Portage. We can however add it to the Java overlay.

@hydrapolic
Copy link
Contributor Author

Why @monsieurp?

@gentoo-bot gentoo-bot merged commit e2cb74e into gentoo:master Jan 13, 2016
@hydrapolic hydrapolic deleted the yuicompressor branch January 18, 2016 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package.
Projects
None yet
3 participants