dev-python/nbval: A py.test plugin to validate Jupyter notebook #6247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pull Request assignment Areas affected: ebuilds dev-python/nbval: @gentoo/proxy-maint (new package) Bugs linked: 638208 |
gentoo-repo-qa-bot
added
new package
SoapGentoo
suggested changes
Nov 25, 2017
dev-python/nbval/nbval-0.7.ebuild
Outdated
| dev-python/sympy[${PYTHON_USEDEP}] | ||
| dev-python/matplotlib[${PYTHON_USEDEP}] | ||
| dev-python/pytest-cov[${PYTHON_USEDEP}] | ||
| sys-devel/make |
There was a problem hiding this comment.
no need to add make to dependencies
dev-python/nbval/nbval-0.7.ebuild
Outdated
| " | ||
|
|
||
| python_test() { | ||
| make test |
There was a problem hiding this comment.
never use naked make, always emake
The plugin adds functionality to py.test to recognise and collect Jupyter notebooks. The intended purpose of the tests is to determine whether execution of the stored inputs match the stored outputs of the .ipynb file. Whilst also ensuring that the notebooks are running without errors. The tests were designed to ensure that Jupyter notebooks (especially those for reference and documentation), are executing consistently. Each cell is taken as a test, a cell that doesn't reproduce the expected output will fail. Bug: https://bugs.gentoo.org/638208 Package-Manager: Portage-2.3.13, Repoman-2.3.3
|
@SoapGentoo Thanks for the annotations. All done. |
monsieurp
approved these changes
Nov 30, 2017
NeddySeagoon
pushed a commit
to NeddySeagoon/gentoo-arm64
that referenced
this pull request
Dec 3, 2017
nbval is a py.test plugin to validate Jupyter notebook. The plugin adds functionality to py.test to recognise and collect Jupyter notebooks. The intended purpose of the tests is to determine whether execution of the stored inputs match the stored outputs of the .ipynb file. Whilst also ensuring that the notebooks are running without errors. The tests were designed to ensure that Jupyter notebooks (especially those for reference and documentation), are executing consistently. Each cell is taken as a test, a cell that doesn't reproduce the expected output will fail. Closes: https://bugs.gentoo.org/638208 Closes: gentoo#6247 Package-Manager: Portage-2.3.13, Repoman-2.3.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plugin adds functionality to py.test to recognise and collect Jupyter notebooks.
The intended purpose of the tests is to determine whether execution of the stored
inputs match the stored outputs of the .ipynb file. Whilst also ensuring that the
notebooks are running without errors.
The tests were designed to ensure that Jupyter notebooks (especially those for reference
and documentation), are executing consistently.
Each cell is taken as a test, a cell that doesn't reproduce the expected output will fail.
Bug: https://bugs.gentoo.org/638208
Package-Manager: Portage-2.3.13, Repoman-2.3.3