media-plugins/alsaequal: Fix https://bugs.gentoo.org/499298 reported by Tiago Resende #6255
Conversation
|
Pull Request assignment Areas affected: ebuilds media-plugins/alsaequal: @gentoo/proaudio No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message. If there is no bug open for this pull request, please open one. Otherwise, please link it to the commit messages as noted above. |
gentoo-repo-qa-bot
added
assigned
bassdr
force-pushed
the
alsaequal-0.7
branch
from
725c3f0
to
17440d5
Compare
|
👍 All QA issues have been fixed! |
Bug: https://bugs.gentoo.org/499298 Package-Manager: Portage-2.3.13, Repoman-2.3.3
bassdr
force-pushed
the
alsaequal-0.7
branch
from
5b2bf93
to
a93db1f
Compare
|
@bassdr Do you still intend to work on this PR? |
|
Yes, why not? I did not have any feedback though... I am using alsaequal on one of my box and it works using my fork... |
| @@ -1,16 +1,16 @@ | |||
| # Copyright 1999-2014 Gentoo Foundation | |||
| # Copyright 1999-2017 Gentoo Foundation | |||
There was a problem hiding this comment.
You are performing a rename in Git for this. By doing so, you are dropping the 0.6 ebuild which is stable. This should just be a new ebuild in the tree for 0.7.
Also, adjust the commit to have a proper GLEP66 tag.
e.g. drop "Fix https://bugs.gentoo.org/499298" from the summary and put it in the proper GLEP66 tag.
| HOMEPAGE="http://www.thedigitalmachine.net/alsaequal.html" | ||
| SRC_URI="http://www.thedigitalmachine.net/tools/${P}.tar.bz2" | ||
| DESCRIPTION="A real-time adjustable equalizer plugin for ALSA" | ||
| HOMEPAGE="https://github.com/bassdr/alsaequal" |
There was a problem hiding this comment.
Why not use ${PN} here as well?
|
No activity in 45+ days. |
Bug: https://bugs.gentoo.org/499298
Package-Manager: Portage-2.3.13, Repoman-2.3.3