Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-misc/electrum: add dev-lang/python-3.6 support #6575

Closed
wants to merge 1 commit into from
Closed

net-misc/electrum: add dev-lang/python-3.6 support #6575

wants to merge 1 commit into from

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Dec 18, 2017

No description provided.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: net-misc/electrum

net-misc/electrum: @blueness, luke-jr+gentoobugs[at]utopios.org, maksverver[at]geocities.com

No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message.

If there is no bug open for this pull request, please open one. Otherwise, please link it to the commit messages as noted above.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Dec 18, 2017
@XVilka
Copy link
Contributor Author

XVilka commented Dec 20, 2017

See bug https://bugs.gentoo.org/641778

@SoapGentoo
Copy link
Member

@mgorny LINGUAS hackery ahoy, what do we do? remove all of the LINGUAS hacks?

SoapGentoo
SoapGentoo suggested changes Dec 23, 2017
View reviewed changes
net-misc/electrum/electrum-3.0.3.ebuild Outdated
@@ -3,7 +3,7 @@

EAPI="6"

PYTHON_COMPAT=( python3_{4,5} )
PYTHON_COMPAT=( python3_{4,5,6} )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this ebuild has a number of issues, like depending on naked dev-lang/python, which should use ${PYTHON_DEPS} instead

net-misc/electrum/electrum-3.0.3.ebuild Outdated
@@ -3,7 +3,7 @@

EAPI="6"

PYTHON_COMPAT=( python3_{4,5} )
PYTHON_COMPAT=( python3_{4,5,6} )
PYTHON_REQ_USE="ncurses?"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add EAPI-4 default specifier here (-)

net-misc/electrum/electrum-3.0.3.ebuild Outdated
@@ -3,7 +3,7 @@

EAPI="6"

PYTHON_COMPAT=( python3_{4,5} )
PYTHON_COMPAT=( python3_{4,5,6} )
PYTHON_REQ_USE="ncurses?"

inherit distutils-r1 gnome2-utils xdg-utils
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doicon requires desktop.eclass

@XVilka
Copy link
Contributor Author

XVilka commented Dec 29, 2017

I updated it as requested

@XVilka
Copy link
Contributor Author

XVilka commented Jan 11, 2018

I saw electrum was just bumped to 3.0.5. Is there any decision on this one?

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

monsieurp
monsieurp approved these changes Jan 26, 2018
View reviewed changes
Copy link
Member

@monsieurp monsieurp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Merging underway.

@XVilka XVilka deleted the patch-6 branch April 16, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoapGentoo SoapGentoo SoapGentoo requested changes

@monsieurp monsieurp monsieurp approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
4 participants
@XVilka @gentoo-repo-qa-bot @SoapGentoo @monsieurp