-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-misc/gcal: 4.1 version bump #6614
Conversation
Pull Request assignment Areas affected: ebuilds app-misc/gcal: @gentoo/shell-tools No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message. If there is no bug open for this pull request, please open one. Otherwise, please link it to the commit messages as noted above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
thank you for the PR and congratulations with the first one =)
Please read this page:
https://devmanual.gentoo.org/ebuild-maintenance/index.html#git-commit-message-format
Your commit message should follow required format.
|
||
LICENSE="GPL-3" | ||
SLOT="0" | ||
KEYWORDS="amd64 ~arm ppc x86 ~amd64-linux ~x86-linux ~ppc-macos ~x86-macos" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should at least drop all stable keywords to unstable if you bump a version.
In this case ppc x86 and amd64 should have ~ in front of them.
https://devmanual.gentoo.org/keywording/index.html#keywording-on-upgrades
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a tool for this:
ekeyword ~all gcal-4.1.ebuild
We also have vim and Emacs modes that make this easy, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @gyakovlev I have some issues with repoman..
Probably I missed something.
I cloned this repo in ~/opt/src/gentoo
(while emerge still watches the one in /usr/portage
). When I run
$ repoman scan
RepoMan scours the neighborhood...
*** the local copy of metadata.xsd needs to be refetched, doing that now
Repoman: Need user access
what does this mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Sorry for taking so long to respond. Your PR looks good overall even though your commit message as well as the keywording is wrong. I'll fix that prior to merging.
thanks @monsieurp, I would be glad to fix the above issue.. do you have any hint on how to make repoman work? |
Hey @asartori86. How do you mean? It should work out of the box. Emerge it and there you have it. |
@monsieurp, this issue :)
|
@asartori86 See Gentoo bugs #574130 and #596670. |
This is my first PR for an ebuild. not sure if I did it the right way..