Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-libs/device-atlas-api-c: Version bump #6784

Closed
wants to merge 1 commit into from

Conversation

bjacquin
Copy link
Contributor

@bjacquin bjacquin commented Jan 7, 2018

In order to move Manifest to BLAKE2B as requested in bug #642874, old
version have to be removed since sources are not available anymore

Package-Manager: Portage-2.3.13, Repoman-2.3.3

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-libs/device-atlas-api-c

dev-libs/device-atlas-api-c: @bjacquin, @gentoo/proxy-maint

No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jan 7, 2018
@candrews
Copy link
Member

Unfortunately, we can't merge this because you're removing stable versions.

You need to request version 2.1.3 to be keyworded "amd64 arm ppc x86" - then this PR can be merged. See https://wiki.gentoo.org/wiki/Stable_request

@bjacquin
Copy link
Contributor Author

@devnexen can you please provide sources for older version for rehash ?

@devnexen
Copy link
Contributor

@bjacquin Sorry I did not see this PR before but within few weeks we ll release 2.1.4 and drop 2.1.3

@bjacquin
Copy link
Contributor Author

@devnexen well, the thing is that we need to keep at least one version as stable to make the tree consistent. One stable haproxy must depend on a stable dev-libs/device-atlas-api-c. As of today, 2.1.2_p1 is stable but we are not able to fetch the source to regenerate the Manifest hashes.

Could you post on your website the source code for 2.1.2_p1 ?

@devnexen
Copy link
Contributor

I m not in control for the website and we do not keep old versions (especially in this case these are bug fixes no new features).

@devnexen
Copy link
Contributor

Would it be enough to wait 2.1.4 and keep the source of 2.1.3 ? Sorry if it s not ideal but do not have better idea.

@bjacquin
Copy link
Contributor Author

@candrews what would be your advise here ?

@candrews
Copy link
Member

I suggest you update this PR to only do the version bump - leave the old versions alone. https://bugs.gentoo.org/642874 will remain open.

Then, open a stabilization request for the new version just added. Once the new version is stabilized so it has the same keywords as the old version, then you can submit a PR removing the old versions which will close https://bugs.gentoo.org/642874

@bjacquin
Copy link
Contributor Author

Last PR is now only including the version bump

@candrews
Copy link
Member

@mgorny I can't push this change because there's a disallowed hash in the manifest (the pre commit hook fails). Any suggestions?

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

@mgorny
Copy link
Member

mgorny commented Jan 17, 2018

The proxied maintainer needs to update hashes for the old versions first.

@candrews
Copy link
Member

@mgorny which he cannot do, as earlier comments indicate.

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@candrews, have you build-tested this package?

I'm going to commented the hook out and merge it upon confirmation. However, I don't want to have to test it.

That said, if people can't reliably fetch old versions, then this package should have never became stable. For this reason, I'd like to ask you to package.use.stable.mask it for haproxy, and remove stable keywords.

fi

if use examples; then
insinto /usr/share/doc/${P}/examples
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docinto/dodoc. I'm going to fix this one for you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in last PR

Copy link
Member

@mgorny mgorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

>>> Emerging (1 of 1) dev-libs/device-atlas-api-c-2.1.3::gentoo
 * deviceatlas-enterprise-c-2.1.3.tgz BLAKE2B SHA512 size ;-) ...                                                                           [ ok ]
>>> Unpacking source...
>>> Unpacking deviceatlas-enterprise-c-2.1.3.tgz to /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work
>>> Source unpacked in /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work
>>> Preparing source in /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work/deviceatlas-enterprise-c-2.1.3 ...
 * Applying 2.1.3-src-cmakelists.patch ...
1 out of 2 hunks FAILED -- saving rejects to file Src/CMakeLists.txt.rej                                                                    [ !! ]
 * ERROR: dev-libs/device-atlas-api-c-2.1.3::gentoo failed (prepare phase):
 *   patch -p1  failed with /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/files/2.1.3-src-cmakelists.patch

@bjacquin
Copy link
Contributor Author

@devnexen according to @mgorny comments, would you be able to find a way to make old releases available on the website ? Could you talk internally on this matter ?

Package-Manager: Portage-2.3.13, Repoman-2.3.3
@bjacquin
Copy link
Contributor Author

docinto/dodoc fixed in last PR.
Patch fixed as well, this is due to rebase fixing whitespaces.

@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/a70fa2e76/output.html#sys-libs/glibc

@devnexen
Copy link
Contributor

Thanks @bjacquin @mgorny 👍

NeddySeagoon pushed a commit to NeddySeagoon/gentoo-arm64 that referenced this pull request Jan 25, 2018
Closes: gentoo#6784
Package-Manager: Portage-2.3.13, Repoman-2.3.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
5 participants