-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-libs/device-atlas-api-c: Version bump #6784
Conversation
Pull Request assignment Areas affected: ebuilds dev-libs/device-atlas-api-c: @bjacquin, @gentoo/proxy-maint No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message. |
Unfortunately, we can't merge this because you're removing stable versions. You need to request version 2.1.3 to be keyworded "amd64 arm ppc x86" - then this PR can be merged. See https://wiki.gentoo.org/wiki/Stable_request |
@devnexen can you please provide sources for older version for rehash ? |
@bjacquin Sorry I did not see this PR before but within few weeks we ll release 2.1.4 and drop 2.1.3 |
@devnexen well, the thing is that we need to keep at least one version as stable to make the tree consistent. One stable haproxy must depend on a stable dev-libs/device-atlas-api-c. As of today, 2.1.2_p1 is stable but we are not able to fetch the source to regenerate the Manifest hashes. Could you post on your website the source code for 2.1.2_p1 ? |
I m not in control for the website and we do not keep old versions (especially in this case these are bug fixes no new features). |
Would it be enough to wait 2.1.4 and keep the source of 2.1.3 ? Sorry if it s not ideal but do not have better idea. |
@candrews what would be your advise here ? |
I suggest you update this PR to only do the version bump - leave the old versions alone. https://bugs.gentoo.org/642874 will remain open. Then, open a stabilization request for the new version just added. Once the new version is stabilized so it has the same keywords as the old version, then you can submit a PR removing the old versions which will close https://bugs.gentoo.org/642874 |
d47440f
to
c7f306e
Compare
Last PR is now only including the version bump |
@mgorny I can't push this change because there's a disallowed hash in the manifest (the pre commit hook fails). Any suggestions? |
👍 All QA issues have been fixed! |
The proxied maintainer needs to update hashes for the old versions first. |
@mgorny which he cannot do, as earlier comments indicate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@candrews, have you build-tested this package?
I'm going to commented the hook out and merge it upon confirmation. However, I don't want to have to test it.
That said, if people can't reliably fetch old versions, then this package should have never became stable. For this reason, I'd like to ask you to package.use.stable.mask it for haproxy, and remove stable keywords.
fi | ||
|
||
if use examples; then | ||
insinto /usr/share/doc/${P}/examples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docinto/dodoc. I'm going to fix this one for you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in last PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
>>> Emerging (1 of 1) dev-libs/device-atlas-api-c-2.1.3::gentoo
* deviceatlas-enterprise-c-2.1.3.tgz BLAKE2B SHA512 size ;-) ... [ ok ]
>>> Unpacking source...
>>> Unpacking deviceatlas-enterprise-c-2.1.3.tgz to /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work
>>> Source unpacked in /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work
>>> Preparing source in /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/work/deviceatlas-enterprise-c-2.1.3 ...
* Applying 2.1.3-src-cmakelists.patch ...
1 out of 2 hunks FAILED -- saving rejects to file Src/CMakeLists.txt.rej [ !! ]
* ERROR: dev-libs/device-atlas-api-c-2.1.3::gentoo failed (prepare phase):
* patch -p1 failed with /tmp/portage/dev-libs/device-atlas-api-c-2.1.3/files/2.1.3-src-cmakelists.patch
Package-Manager: Portage-2.3.13, Repoman-2.3.3
docinto/dodoc fixed in last PR. |
c7f306e
to
2fafde7
Compare
😞 The QA check for this pull request has found the following issues: Issues inherited from Gentoo (may be modified by PR): |
Closes: gentoo#6784 Package-Manager: Portage-2.3.13, Repoman-2.3.3
In order to move Manifest to BLAKE2B as requested in bug #642874, old
version have to be removed since sources are not available anymore
Package-Manager: Portage-2.3.13, Repoman-2.3.3