Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

games-emulation/ppsspp:new ebuild #682

Merged
merged 1 commit into from Jan 19, 2016
Merged

games-emulation/ppsspp:new ebuild #682

merged 1 commit into from Jan 19, 2016

Conversation

RobinDX
Copy link
Contributor

@RobinDX RobinDX commented Jan 19, 2016

No description provided.

@monsieurp
Copy link
Member

Robin... using git for the -9999 ebuild is fine and you should leave it as such. But for the other two ebuilds? Why not fetching the repository content from github directly? Namely, https://github.com/hrydgard/ppsspp/archive/v1.1.1.zip and https://github.com/hrydgard/ppsspp/archive/v1.1.0.zip. We much prefer dealing with an archive than checking out "live" from a repo. Thanks for rewriting these 2 ebuilds and changing this behaviour.

@monsieurp
Copy link
Member

@gentoo/proxy-maint

@monsieurp monsieurp added new package The PR is adding a new package. assigned PR successfully assigned to the package maintainer(s). labels Jan 19, 2016
@RobinDX
Copy link
Contributor Author

RobinDX commented Jan 19, 2016

@monsieurp
Because ppsspp use a lot of submodules on github,use GIT-R3.ECLASS can easily fetch them.
Use directly link cannot use GIT-R3.ECLASS anymore.
And set a EGIT_COMMIT value can set the version of main source code.
The submodules have no version and often change.
So if use zip download links,it impossible to get the submodules zip files sha256 sum in Manifest.

@RobinDX
Copy link
Contributor Author

RobinDX commented Jan 19, 2016

So I choose the easy way.

@RobinDX
Copy link
Contributor Author

RobinDX commented Jan 19, 2016

@monsieurp
Copy link
Member

OK. Fair enough. I didn't know about the way the PPSSPP project manages modules. Let's merge the PR then. There are some minor mistakes (missing dies) that I will fix after merging.

@gentoo-bot gentoo-bot merged commit 32516e8 into gentoo:master Jan 19, 2016
@monsieurp
Copy link
Member

Merged. Thank you. You're in charge of that package from now on. Enjoy!

@RobinDX RobinDX deleted the ppsspp branch January 20, 2016 00:35
@monsieurp
Copy link
Member

@RobinDX
There's a small bug wrt this package. Please see https://bugs.gentoo.org/show_bug.cgi?id=572606 and check your emails (this report has also been forwarded to your email address). Thanks!

@RobinDX
Copy link
Contributor Author

RobinDX commented Jan 29, 2016

@monsieurp
#738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package.
Projects
None yet
3 participants