Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

media-gfx/gpicview: update GTK+ icon cache and xdg desktop database #6920

Closed
wants to merge 1 commit into from
Closed

media-gfx/gpicview: update GTK+ icon cache and xdg desktop database #6920

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Jan 21, 2018

  • fix QA warnings

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: media-gfx/gpicview

media-gfx/gpicview: @gentoo/graphics, @gentoo/lxde

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jan 21, 2018
titanofold
titanofold suggested changes Jan 25, 2018
View reviewed changes
Copy link
Member

@titanofold titanofold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More than you intended, probably, but there's some easy fixes we should have done.

media-gfx/gpicview/gpicview-0.2.5-r1.ebuild Outdated
src_install() {
emake DESTDIR="${D}" install
dodoc AUTHORS
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src_install is unnecessary. It doesn't deviate from the default. Go ahead and delete it.

media-gfx/gpicview/gpicview-0.2.5-r1.ebuild Outdated
LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~alpha ~amd64 ~arm ~arm64 ~ppc ~x86 ~arm-linux ~x86-linux"
IUSE=""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete empty variables.

media-gfx/gpicview/gpicview-0.2.5-r1.ebuild Outdated
DEPEND="${RDEPEND}
>=dev-util/intltool-0.40
virtual/pkgconfig
sys-devel/gettext"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical, please, grouping use flag constraint, version constraint, and bare depends together in the same order for each *DEPEND var.

@stha09
media-gfx/gpicview: update GTK+ icon cache and xdg desktop database
173f4dd 
Package-Manager: Portage-2.3.19, Repoman-2.3.6
@ghost
Copy link
Author

ghost commented Jan 26, 2018 •
edited by ghost

Thanks for review, hope I didn't miss something.

@gentoo-repo-qa-bot
Copy link
Collaborator

👍 All QA issues have been fixed!

@ghost ghost deleted the gpicview branch January 27, 2018 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
Milestone
No milestone
3 participants
@gentoo-repo-qa-bot @titanofold @stha09