-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sci-biology/qrna: add missing SLOT for hmmer #7134
Conversation
Pull Request assignment Areas affected: ebuilds sci-biology/qrna: @gentoo/sci-biology No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers. In order to force reassignment and/or bug reference scan, please append |
@@ -16,7 +16,7 @@ IUSE="" | |||
|
|||
RDEPEND=" | |||
dev-lang/perl | |||
sci-biology/hmmer" | |||
sci-biology/hmmer:2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this will require a revbump, so please bump this to -r3 and remove -r2 in a separate commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. BTW, what would be wrong with git mv qrna-2.0.3c-r2.ebuild qrna-2.0.3c-r3.ebuild
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, easy ability to revert atomic changes. https://wiki.gentoo.org/wiki/Gentoo_GitHub#Separate_.28or_.22atomic.22.29_commits
Please squash your commits into one |
Pull request CI report Report generated at: 2018-02-23 16:03 UTC All QA issues have been fixed! |
Sorry for this taking so long. Next time, please make sure not to merge commits into your branch, always rebase. |
Actually, is this really necessary? At least build of qrna seems to work fine with hmmer:0. Can you point at a bug? |
hmmer-1 and -2 a -3 use different algorithms here and there but upstream refuses to rename binaries to distinguish they do different things. That is why hmmer:2 and hmmer:3 cannot coexist at the same time, unless somebody patches the hmmer itself and all 3rd-party apps calling them. I tried to update the master (not this particular branch) but something went wrong again. I am sorry. |
No description provided.