Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-biology/qrna: add missing SLOT for hmmer #7134

Closed
wants to merge 2 commits into from
Closed

sci-biology/qrna: add missing SLOT for hmmer #7134

wants to merge 2 commits into from

Conversation

mmokrejs
Copy link
Contributor

@mmokrejs mmokrejs commented Feb 9, 2018

No description provided.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: sci-biology/qrna

sci-biology/qrna: @gentoo/sci-biology

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Feb 9, 2018
@@ -16,7 +16,7 @@ IUSE=""

RDEPEND="
dev-lang/perl
sci-biology/hmmer"
sci-biology/hmmer:2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this will require a revbump, so please bump this to -r3 and remove -r2 in a separate commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. BTW, what would be wrong with git mv qrna-2.0.3c-r2.ebuild qrna-2.0.3c-r3.ebuild?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SoapGentoo
Copy link
Member

Please squash your commits into one

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2018-02-23 16:03 UTC
Newest commit scanned: f16f534
Status: ✅ good

All QA issues have been fixed!

@a17r a17r added the fix on merge There is at least one issue still needing fixing. Please read the comments and fix it while merging. label Apr 5, 2018
@a17r
Copy link
Member

a17r commented Apr 5, 2018

Sorry for this taking so long. Next time, please make sure not to merge commits into your branch, always rebase.

@a17r
Copy link
Member

a17r commented Apr 5, 2018

Actually, is this really necessary? At least build of qrna seems to work fine with hmmer:0. Can you point at a bug?

@mmokrejs
Copy link
Contributor Author

mmokrejs commented Apr 5, 2018

Actually, is this really necessary? At least build of qrna seems to work fine with hmmer:0. Can you point at a bug?

hmmer-1 and -2 a -3 use different algorithms here and there but upstream refuses to rename binaries to distinguish they do different things. That is why hmmer:2 and hmmer:3 cannot coexist at the same time, unless somebody patches the hmmer itself and all 3rd-party apps calling them.

I tried to update the master (not this particular branch) but something went wrong again. I am sorry.

@gentoo-bot gentoo-bot closed this in 55b9d1d Apr 5, 2018
@mmokrejs mmokrejs deleted the add_hmmer_slot branch April 6, 2018 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). fix on merge There is at least one issue still needing fixing. Please read the comments and fix it while merging. no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants