net-nntp/suck: Add version 4.3.3 #7185
Conversation
gentoo-repo-qa-bot
added
maintainer-needed
net-nntp/suck/suck-4.3.3.ebuild
Outdated
| -e 's:/var/lib/news/history:/var/spool/news/db/history:' \ | ||
| suck_config.h || die "path adaption sed failed" | ||
|
|
||
| default |
There was a problem hiding this comment.
I would recommend to run default as the first thing in src_prepare, so user patches applied in default can not be affected by the sed.
net-nntp/suck/suck-4.3.3.ebuild
Outdated
| src_prepare() { | ||
| # Fix paths to the locations in Gentoo | ||
| sed -i \ | ||
| -e 's:/usr/bin/rnews:/usr/lib/news/bin/rnews:' \ |
There was a problem hiding this comment.
Is this using rnews from net-nntp/inn? That package seems to install the binary to /usr/$(get_libdir)/news/$(get_libdir), so the sed should do the same (hardcoded lib is almost always wrong). net-nntp/inn is probably missing in RDEPEND as lpost seems useless without it. This would introduce a runtime-only dependency, usually if there are both DEPEND- and RDEPEND-only deps we use a helper var like COMMON_DEPEND that both DEPEND and RDEPEND can inherit from.
There was a problem hiding this comment.
Ok! :) Will change this. However I suppose you had a typo in: /usr/$(get_libdir)/news/$(get_libdir) and you mean: /usr/$(get_libdir)/news/bin/rnews ?
There was a problem hiding this comment.
yes that must have been a copy-paste error, I just looked at inn ebuild without having it installed
net-nntp/suck/suck-4.3.3.ebuild
Outdated
|
|
||
| DEPEND="sys-libs/db | ||
| perl? ( dev-lang/perl ) | ||
| ssl? ( dev-libs/openssl )" |
There was a problem hiding this comment.
At least openssl is linked to, so this needs to go into RDEPEND (and DEPEND can inherit RDEPEND not to duplicate the line). I also saw sys-libs/gdbm.5 be linked against, so same there. Both dependencies need to trigger rebuild of suck on subslot upgrade, in case of openssl append :0= (another slot exists there but we need 0), for gdbm append := to achieve that.
net-nntp/suck/suck-4.3.3.ebuild
Outdated
| LICENSE="public-domain" | ||
| SLOT="0" | ||
| KEYWORDS="~amd64 ~ppc ~x86" | ||
| IUSE="ssl perl" |
There was a problem hiding this comment.
minor nitpick, but in general we keep things sorted, which becomes more important with growing lists of IUSE and DEPENDs.
There was a problem hiding this comment.
Sorry, what do you mean by sorted here? Listing ssl after perl to have alphabetically ordered?
net-nntp/suck/suck-4.3.3.ebuild
Outdated
| IUSE="ssl perl" | ||
|
|
||
| DEPEND="sys-libs/db | ||
| perl? ( dev-lang/perl ) |
There was a problem hiding this comment.
The perl flag does not seem to do much - part of the problem is that configure.ac is searching for libperl.a, which does not exist in Gentoo, but even if I change it to libperl.so there is no difference in the install image. It does not set a build switch either. Do you have an idea?
There was a problem hiding this comment.
I'm not sure how it was in suck 4.3.2, probably it had some effect there. In 4.3.3 maybe it can be omitted, I'm still learning about the package. I would let it like this for now and try to investigate later on more, would that be ok?
jubalh
changed the title
gentoo-repo-qa-bot
changed the title
gentoo-repo-qa-bot
added
maintainer-needed
Closes: https://bugs.gentoo.org/232581 Closes: https://bugs.gentoo.org/622880 Package-Manager: Portage-2.3.19, Repoman-2.3.6
|
Pull request CI report Report generated at: 2018-02-15 13:17 UTC Issues already there before the PR (double-check them): |
Closes: https://bugs.gentoo.org/232581 Closes: https://bugs.gentoo.org/622880 Package-Manager: Portage-2.3.19, Repoman-2.3.6 Closes: gentoo#7185
Package-Manager: Portage-2.3.19, Repoman-2.3.6