dev-nodejs/chalk and its dependencies #7427
Conversation
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Package-Manager: Portage-2.3.19, Repoman-2.3.6
Include new dev-nodejs category for this package and its dependencies. Package-Manager: Portage-2.3.19, Repoman-2.3.6
gentoo-repo-qa-bot
added
the
need assignment
|
Pull request CI report Report generated at: 2018-03-12 04:31 UTC Issues already there before the PR (double-check them): |
mgorny
removed
the
need assignment
|
Pull Request assignment Areas affected: other files, profiles @gentoo/github No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment. In order to force reassignment and/or bug reference scan, please append |
gentoo-repo-qa-bot
added
the
need assignment
mgorny
added
new package
|
Ahh, you're adding a new category, that's what confuses the hell out of assignment script. That said, I believe adding a new category requires a RFC to gentoo-dev@ first. Feel free to reference this PR as example of what would land in the new category. |
|
Oh, and new category must be the first commit, otherwise the added packages are invalid. |
|
|
||
| src_install() { | ||
| insinto "/usr/$(get_libdir)/node_modules/${PN}" | ||
| doins -r *.js |
There was a problem hiding this comment.
Why -r? Are there .js directories in node?
| } | ||
|
|
||
| src_test() { | ||
| /usr/bin/node test.js |
There was a problem hiding this comment.
You're missing error handling here (|| die).
| <upstream> | ||
| <remote-id type="github">colorjs/color-name</remote-id> | ||
| </upstream> | ||
| </pkgmetadata> |
|
I am having quite a bit of trouble getting subscribed to the gentoo-dev mailing list and posting. I'm not sure if new council decisions have anything to do with it: https://bugs.gentoo.org/650964 I registered with the wrong e-mail address by accident. I can't seem to get registered with my main e-mail, and can't post from either. If I send you the message can you forward it to the list for me? |
|
We've gotten your mail just fine. |
mgorny
added
the
do not merge
|
I'm going to mark this red so that it isn't accidentally merged before people have a chance for feedback. |
|
No activity in 60+ days. |
What I read in the mailing list has basically said taking on packaging node modules is torture, but I'd still like to take it on. My endgame here is to eventually have all the nodejs modules I need to build Visual Studio Code OSS and bring it in.
The last commit, for chalk, adds the dev-nodejs category.
Not sure what to do about the x32 profiles repoman is complaining about:
dependency.badindev 4
dev-nodejs/color-name/color-name-1.1.3.ebuild: DEPEND: ~amd64(default/linux/amd64/17.0/x32)
['net-libs/nodejs']
dev-nodejs/color-name/color-name-1.1.3.ebuild: RDEPEND: ~amd64(default/linux/amd64/17.0/x32)
['net-libs/nodejs']
dev-nodejs/color-name/color-name-1.1.3.ebuild: DEPEND: ~amd64(hardened/linux/amd64/x32)
['net-libs/nodejs']
dev-nodejs/color-name/color-name-1.1.3.ebuild: RDEPEND: ~amd64(hardened/linux/amd64/x32)
['net-libs/nodejs']
Related to bug: "V8 upstream said they won't support x32, bug #423815" But did that get resolved and nodejs never got unmasked for x32?