app-misc/prog-express: New package #7602

ConiKost · 2018-03-25T02:30:01Z

Zlogene · 2018-03-25T09:32:02Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+	doins "${FILESDIR}"/pe.exe.config
+
+	# Install udev rule
+	insinto "/lib/udev/rules.d"


please use udev.eclass for this

Thanks, I will update the eBuild to use the udev class.

Zlogene · 2018-03-25T09:33:48Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+	done
+
+	# Install bin files
+	dobin "usr/bin/bxusb" "usr/bin/bxusb-gui" "usr/bin/prog-express"


Minor: you do not need all double quotes for ebuild helpers here. I mean insinto dosbin doins domenu, doman etc

Okay, I will revert those double quotes, personally, I like them.

Zlogene · 2018-03-25T09:38:08Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+EAPI=6
+
+inherit eutils multilib


Any explanation why are you using multilib.eclass here? I guess you did this to provide $(get_libdir) feature, but this is a built-in function for EAPI=6

You are right, I wasn't aware, that this is part if EAPI=6. Will be fixed.

Zlogene · 2018-03-25T09:42:08Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+EAPI=6
+
+inherit eutils multilib


I do not see any reason to use eutils.eclass here as well, please use desktop.eclass, it provides functionality to handle menus and icons :)

Ah, I see, will be changed.

Zlogene · 2018-03-25T09:47:35Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+QA_PREBUILT="usr/bin/bxusb usr/bin/bxusb-gui usr/bin/prog-express usr/sbin/bxfxload"
+
+src_unpack() {


please do not handle this manually, use unpacker.eclass for this purpose

Thanks, I will update the eBuild.

ConiKost · 2018-03-25T12:29:56Z

@Zlogene: Thank you very much for you review, I've pushed a new version, which adds all of your requested changes.

Zlogene · 2018-03-25T12:31:20Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+src_install() {
+	# Fix lib path
+	for file in bxusb bxusb-gui prog-express; do


Could you move this one into src_prepare()? All the preparations had better go there

Thanks. I've pushed a new version and move that part into src_preare().

gentoo-repo-qa-bot · 2018-03-25T20:12:00Z

Pull Request assignment

Areas affected: ebuilds, other files, profiles
Packages affected: app-misc/prog-express

app-misc/prog-express: @gentoo/proxy-maint (new package)

Bugs linked: 651396

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Closes: gentoo#8228

Package-Manager: Portage-2.3.24, Repoman-2.3.6

Package-Manager: Portage-2.3.36, Repoman-2.3.9 RepoMan-Options: --ignore-arches

Package-Manager: Portage-2.3.33, Repoman-2.3.9 Closes: gentoo#8204

Closes: https://bugs.gentoo.org/612048 Closes: gentoo#8055

Package-Manager: Portage-2.3.36, Repoman-2.3.9

EAPI 6 Package-Manager: Portage-2.3.36, Repoman-2.3.9

Uses deprecated EAPI 2. Package-Manager: Portage-2.3.36, Repoman-2.3.9

EAPI 6. Package-Manager: Portage-2.3.36, Repoman-2.3.9

Reported-by: rypervenche <contact@ryper.org> Closes: https://bugs.gentoo.org/602728 Package-Manager: Portage-2.3.36, Repoman-2.3.9

EAPI 6. Package-Manager: Portage-2.3.36, Repoman-2.3.9

Package-Manager: Portage-2.3.36, Repoman-2.3.9

Closes: https://bugs.gentoo.org/655472 Package-Manager: Portage-2.3.36, Repoman-2.3.9

Package-Manager: Portage-2.3.36, Repoman-2.3.9

Includes mozcoreconf-v6 and mozconfig-v6.60 eclasses Closes: http://bugs.gentoo.org/653678 Closes: http://bugs.gentoo.org/655396 Closes: http://bugs.gentoo.org/655022 Package-Manager: Portage-2.3.24, Repoman-2.3.6

Package-Manager: Portage-2.3.24, Repoman-2.3.6

ESR 52.8.0 needs testing before stabilization Package-Manager: Portage-2.3.24, Repoman-2.3.6

Can be used as client for older bacula server installations. Bug: https://bugs.gentoo.org/651078 Package-Manager: Portage-2.3.36, Repoman-2.3.9

mgorny · 2018-06-03T08:13:22Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+	virtual/libusb:1
+	virtual/udev"
+
+RESTRICT="strip"


License says: Restrictions: You are not allowed to modify Prog-Express itself or any parts of it nor apply any kind of reverse engineering to this software or any parts of it.

Shoudn't be strip in that case be set?

As with the other package, we generally don't assume stripping applies here. But it's your choice.

Allright, dropped.

mgorny · 2018-06-03T08:13:40Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+S="${WORKDIR}"
+
+DOCS=( "usr/share/doc/prog-express/changelog.gz" "usr/share/doc/prog-express/manuals" )


Installing gzipped docs is not fine. Unpack it.

Whoops, thanks.

mgorny · 2018-06-03T08:15:45Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+	# Fix lib path on amd64, since it's hardcoded to /usr/lib
+	if use amd64; then
+		for file in bxusb bxusb-gui prog-express; do
+			sed -i -e "s/lib/$(get_libdir)/g" usr/bin/${file} || die


You aren't sed-ing binary files, are you? In any case, I don't see a reason to force lib64 here.

No, this is not a binary, only a script. But I am removing it now, since I will only install to /usr/lib.

mgorny · 2018-06-03T08:16:02Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+}
+
+src_install() {
+	default


What does default do here?

Run einstalldocs?

Make it explicit.

Removed by now. I looked again through it, einstalldocs shouldn't be needed at all in this case.

mgorny · 2018-06-03T08:16:32Z

app-misc/prog-express/prog-express-3.7.8.ebuild

+
+	dosbin usr/sbin/bxfxload
+
+	insinto /usr/$(get_libdir)


Any reason not to use usr/lib?

No. I thought because of 17.1 profiles, I have to install in /usr/lib and /usr/lib64? Is this wrong?

Both locations have their use cases.

Ok, will use /usr/lib.

https://bugs.gentoo.org/651396

Closes: https://bugs.gentoo.org/651396 Package-Manager: Portage-2.3.40, Repoman-2.3.9

mgorny · 2018-06-20T08:23:33Z

licenses/prog-express

+
+Files: *
+Copyright: 2006-2015 Batronix Elektronik <support@batronix.com>
+License: Freeware


@gentoo/licenses, can we fit it with one of the existing licenses?

gentoo-repo-qa-bot · 2018-06-20T09:19:03Z

Pull request CI report

Report generated at: 2018-06-20 09:19 UTC
Newest commit scanned: 087ade3
Status: ✅ good

No issues found

Zlogene suggested changes Mar 25, 2018

View reviewed changes

ConiKost force-pushed the prog-express branch from 64cf2e6 to 1331932 Compare March 25, 2018 12:24

Zlogene suggested changes Mar 25, 2018

View reviewed changes

ConiKost force-pushed the prog-express branch 3 times, most recently from ca176dd to 77fadcc Compare March 25, 2018 12:40

ConiKost force-pushed the prog-express branch 8 times, most recently from 891d21d to aefce93 Compare March 30, 2018 17:14

ConiKost force-pushed the prog-express branch 2 times, most recently from ffd389f to e2cb835 Compare April 28, 2018 08:57

turboscholz and others added 8 commits May 9, 2018 12:57

gnome-extra/gnome-commander: Version bump to 1.8.1

c8992c9

Closes: gentoo#8228

net-ftp/oftpd: ppc/sh stable wrt bug #648398

3e783ac

Package-Manager: Portage-2.3.24, Repoman-2.3.6

net-ftp/oftpd: Drop old

4f5fa2b

Package-Manager: Portage-2.3.24, Repoman-2.3.6

net-firewall/arptables: ppc stable wrt bug #648398

1dfe316

Package-Manager: Portage-2.3.24, Repoman-2.3.6

net-firewall/arptables: Drop old

9dacb76

Package-Manager: Portage-2.3.24, Repoman-2.3.6

sys-fs/eudev: Stable for HPPA too.

4fd89e0

Package-Manager: Portage-2.3.36, Repoman-2.3.9 RepoMan-Options: --ignore-arches

games-fps/urbanterror: Bump to 4.3.3_p20180410.

c50123b

Package-Manager: Portage-2.3.33, Repoman-2.3.9 Closes: gentoo#8204

app-i18n/man-pages-pl: bump to 0.7

5d6169c

Closes: https://bugs.gentoo.org/612048 Closes: gentoo#8055

mgorny and others added 20 commits May 11, 2018 13:50

xfce-extra/xfce4-sensors-plugin: Bump to 1.3.0 (stable)

34d7cb8

xfce-extra/xfce4-sensors-plugin: Strip .la files

b3a09e2

xfce-extra/xfce4-sensors-plugin: Remove unnecessary manualdir hack

5162766

xfce-extra/xfce4-sensors-plugin: Regen GTK+ icon cache

324a74d

media-fonts/nanumfont: Indentation

4ff01d1

Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/nanumfont: Revision bump 2.0-r2

2dac19f

EAPI 6 Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/nanumfont: Remove 2.0-r1

7649414

Uses deprecated EAPI 2. Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/sil-padauk: Revision bump 2.8-r1

37067b3

EAPI 6. Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/sil-arabicfonts: Version bump 2.100

482f79a

Reported-by: rypervenche <contact@ryper.org> Closes: https://bugs.gentoo.org/602728 Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/sil-gentium: Revision bump 5.000-r1

225a03c

EAPI 6. Package-Manager: Portage-2.3.36, Repoman-2.3.9

media-fonts/sil-gentium: Remove 5.000 (r0)

617a8ce

Package-Manager: Portage-2.3.36, Repoman-2.3.9

www-client/firefox: Bump to version 52.8.0

95b9a28

Package-Manager: Portage-2.3.36, Repoman-2.3.9

www-client/firefox: Removed old.

0dd2199

Package-Manager: Portage-2.3.36, Repoman-2.3.9

app-admin/keepassxc: Bump to version 2.3.3

f3187c5

Closes: https://bugs.gentoo.org/655472 Package-Manager: Portage-2.3.36, Repoman-2.3.9

app-misc/wcd: Bump to version 6.0.2

f820eff

Package-Manager: Portage-2.3.36, Repoman-2.3.9

app-misc/wcd: Removed old.

900f4cf

Package-Manager: Portage-2.3.36, Repoman-2.3.9

www-client/firefox: bump to v60

04dbda8

Includes mozcoreconf-v6 and mozconfig-v6.60 eclasses Closes: http://bugs.gentoo.org/653678 Closes: http://bugs.gentoo.org/655396 Closes: http://bugs.gentoo.org/655022 Package-Manager: Portage-2.3.24, Repoman-2.3.6

www-client/firefox: clean up old ESR versions

139889b

Package-Manager: Portage-2.3.24, Repoman-2.3.6

www-client/firefox-bin: bump to 60.0, 52.8.0; cleanup old

39f346a

ESR 52.8.0 needs testing before stabilization Package-Manager: Portage-2.3.24, Repoman-2.3.6

app-backup/bacula: Revbump with dropped Qt4 support.

c6a11f4

Can be used as client for older bacula server installations. Bug: https://bugs.gentoo.org/651078 Package-Manager: Portage-2.3.36, Repoman-2.3.9

ConiKost force-pushed the prog-express branch 2 times, most recently from a40c533 to 6f48650 Compare May 11, 2018 21:24

mgorny requested changes Jun 3, 2018

View reviewed changes

licenses/prog-express: add license for app-misc/prog-express

d4567a0

https://bugs.gentoo.org/651396

ConiKost force-pushed the prog-express branch from 6f48650 to 080f6ff Compare June 19, 2018 21:06

app-misc/prog-express: New package

087ade3

Closes: https://bugs.gentoo.org/651396 Package-Manager: Portage-2.3.40, Repoman-2.3.9

ConiKost force-pushed the prog-express branch from 080f6ff to 087ade3 Compare June 20, 2018 07:52

mgorny reviewed Jun 20, 2018

View reviewed changes

ConiKost mentioned this pull request Jul 7, 2018

app-misc/prog-express: New package #9107

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

app-misc/prog-express: New package #7602

app-misc/prog-express: New package #7602

ConiKost commented Mar 25, 2018

Zlogene Mar 25, 2018

ConiKost Mar 25, 2018

Zlogene Mar 25, 2018

ConiKost Mar 25, 2018

Zlogene Mar 25, 2018 •

edited

ConiKost Mar 25, 2018

Zlogene Mar 25, 2018 •

edited

ConiKost Mar 25, 2018

Zlogene Mar 25, 2018

ConiKost Mar 25, 2018

ConiKost commented Mar 25, 2018

Zlogene Mar 25, 2018

ConiKost Mar 25, 2018

gentoo-repo-qa-bot commented Mar 25, 2018

mgorny Jun 3, 2018

ConiKost Jun 19, 2018

mgorny Jun 20, 2018

ConiKost Jun 20, 2018

mgorny Jun 3, 2018

ConiKost Jun 19, 2018

mgorny Jun 3, 2018

ConiKost Jun 19, 2018

mgorny Jun 3, 2018

ConiKost Jun 19, 2018

mgorny Jun 20, 2018

ConiKost Jun 20, 2018

mgorny Jun 3, 2018

ConiKost Jun 19, 2018

mgorny Jun 19, 2018

ConiKost Jun 19, 2018

mgorny Jun 20, 2018

gentoo-repo-qa-bot commented Jun 20, 2018


		QA_PREBUILT="usr/bin/bxusb usr/bin/bxusb-gui usr/bin/prog-express usr/sbin/bxfxload"

		src_unpack() {


		S="${WORKDIR}"

		DOCS=( "usr/share/doc/prog-express/changelog.gz" "usr/share/doc/prog-express/manuals" )

app-misc/prog-express: New package #7602

app-misc/prog-express: New package #7602

Conversation

ConiKost commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zlogene Mar 25, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Zlogene Mar 25, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ConiKost commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Mar 25, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Jun 20, 2018

Zlogene Mar 25, 2018 •

edited

Zlogene Mar 25, 2018 •

edited