sys-fs/compsize: New ebuild (proxy maintainer) #7660

automorphism88 · 2018-03-27T19:39:55Z

I wrote this ebuild and went to open a bug on Bugzilla so I could submit a PR for it and noticed that bug #646616 already existed, so I didn't open a duplicate. However, this ebuild is my own work, tested by me, and I am willing to proxy-maintain it.

gentoo-repo-qa-bot · 2018-03-27T19:43:08Z

Pull Request assignment

Areas affected: ebuilds
Packages affected: sys-fs/compsize

sys-fs/compsize: @gentoo/proxy-maint (new package)

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and ping us to reset the assignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

mgorny · 2018-03-30T19:02:22Z

sys-fs/compsize/compsize-1.1.ebuild

+# Copyright 1999-2018 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please use the standard order as present in skel:

EAPI inherit .... DESCRIPTION HOMEPAGE SRC_URI LICENSE SLOT KEYWORDS IUSE DEPEND RDEPEND

Please include the appropriate empty lines too.

mgorny · 2018-03-30T19:02:43Z

sys-fs/compsize/compsize-1.1.ebuild

+RDEPEND=""
+inherit flag-o-matic
+# Used in upstream Makefile, but clobbered by portage's CFLAGS
+append-cflags -Wall -std=gnu90


Don't do this in global scope, move it to a phase function.

mgorny · 2018-03-30T19:03:06Z

sys-fs/compsize/compsize-1.1.ebuild

+# Used in upstream Makefile, but clobbered by portage's CFLAGS
+append-cflags -Wall -std=gnu90
+
+if [[ "$PV" = 9999 ]] ; then


Always use ${...} variable form. Also, don't quote inside [[ ... ]].

mgorny · 2018-03-30T19:03:33Z

sys-fs/compsize/compsize-1.1.ebuild

+
+src_install() {
+	# work around Makefile failing to create this directory
+	mkdir -p "${ED}/usr/share/man/man8" || die


mgorny · 2018-03-30T19:04:20Z

sys-fs/compsize/metadata.xml

+  <maintainer type="project">
+    <email>proxy-maint@gentoo.org</email>
+  </maintainer>
+  <longdescription>utility to measure btrfs compression ratio</longdescription>


Remove this, please. It's only necessary when you have a very long description that doesn't fit in ebuild.

mgorny · 2018-03-30T19:04:33Z

sys-fs/compsize/metadata.xml

+    <email>adebeus@gmail.com</email>
+  </maintainer>
+  <maintainer type="project">
+    <email>proxy-maint@gentoo.org</email>


Please include <name/> here (copy it from some other ebuild).

automorphism88 · 2018-03-30T20:20:50Z

The new commit should fix all of these issues.

mgorny

Once done, please squash all you commits into one.

mgorny · 2018-03-30T20:21:59Z

sys-fs/compsize/compsize-1.1.ebuild

+
+if [[ ${PV} = 9999 ]] ; then
+	inherit git-r3
+	KEYWORDS=""


Remove the two empty vars. Otherwise ekeyword used by arch testers will add keywords here.

mgorny · 2018-03-30T20:22:14Z

sys-fs/compsize/compsize-1.1.ebuild

+# Copyright 1999-2018 Gentoo Foundation
+# Distributed under the terms of the GNU General Public License v2
+
+EAPI=6


Please include the appropriate empty lines too.

mgorny · 2018-03-30T20:23:10Z

sys-fs/compsize/compsize-9999.ebuild

@@ -0,0 +1,30 @@
+# Copyright 1999-2018 Gentoo Foundation


Update -9999 as well.

automorphism88 · 2018-03-30T20:27:44Z

How does it look now?

mgorny · 2018-03-30T21:02:49Z

Almost good. One more thing to fix:

>>> /usr/share/man/man8/compsize.8.gz.lz

(my Portage might be stricter than yours)

Please fix the build system not to compress manpages on its own.

automorphism88 · 2018-03-30T21:27:03Z

I actually had put that fix in originally, but replaced it with the mkdir -p in src_install() upon finding that my portage seemed to uncompress the man page before recompressing it, in the interest of keeping the upstream Makefile intact. I've reverted that change, so now the line in the Makefile that gzips the man page into the directory created with mkdir -p is removed with sed, and the man page is manually installed with doman.

gentoo-repo-qa-bot · 2018-03-30T21:28:33Z

Pull request CI report

Report generated at: 2018-03-30 21:28 UTC
Newest commit scanned: da15719
Status: ✅ good

Issues already there before the PR (double-check them):
https://qa-reports.gentoo.org/output/gentoo-ci/5c2cb7f0b/output.html#net-fs/samba

mgorny · 2018-03-30T21:30:55Z

Could you try passing MAN_I= (empty) to emake install? That would probably be a little cleaner than sed ;-).

automorphism88 · 2018-03-30T21:33:53Z

I just tried that, but it doesn't seem to work.

automorphism88 · 2018-03-30T21:41:03Z

In particular, after applying this change:

diff --git a/sys-fs/compsize/compsize-1.1.ebuild b/sys-fs/compsize/compsize-1.1.ebuild
index ad73046..6437dc2 100644
--- a/sys-fs/compsize/compsize-1.1.ebuild
+++ b/sys-fs/compsize/compsize-1.1.ebuild
@@ -21,13 +21,6 @@ SLOT=0
 RDEPEND=""
 DEPEND="sys-fs/btrfs-progs"
 
-src_prepare() {
-	eapply_user
-	# Don't try to install a gzipped manfile during make install, instead
-	# use doman in src_install to ensure that PORTAGE_COMPRESS is used
-	sed -i $'/^\tgzip /d' Makefile || die
-}
-
 src_configure() {
 	# Used in upstream Makefile, but clobbered by portage's CFLAGS
 	append-cflags -Wall -std=gnu90
@@ -35,7 +28,7 @@ src_configure() {
 }
 
 src_install() {
-	emake PREFIX="${ED%/}" install
+	emake MAN_I= PREFIX="${ED%/}" install
 	doman compsize.8
 	einstalldocs
 }

the installation fails with the following:

>>> Install compsize-1.1 into /var/tmp/portage/sys-fs/compsize-1.1/image/ category sys-fs
make -j5 MAN_I= PREFIX=/var/tmp/portage/sys-fs/compsize-1.1/image install 
install -Dm755 compsize /var/tmp/portage/sys-fs/compsize-1.1/image/usr/bin/compsize
gzip -9n <compsize.8 >/var/tmp/portage/sys-fs/compsize-1.1/image/usr/share/man/man8/compsize.8.gz
/bin/sh: 1: cannot create /var/tmp/portage/sys-fs/compsize-1.1/image/usr/share/man/man8/compsize.8.gz: Directory nonexistent

So I'm leaving it as-is for now unless you can suggest a better way to fix it.

mgorny · 2018-03-30T21:48:43Z

Ok, thanks for testing. Let's go with sed then.

gentoo-repo-qa-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Mar 27, 2018

mgorny requested changes Mar 30, 2018

View reviewed changes

automorphism88 force-pushed the compsize branch from afecaaf to d92b69b Compare March 30, 2018 20:19

mgorny reviewed Mar 30, 2018

View reviewed changes

automorphism88 force-pushed the compsize branch 2 times, most recently from 060dcc2 to 7582d10 Compare March 30, 2018 20:26

automorphism88 force-pushed the compsize branch from 7582d10 to da15719 Compare March 30, 2018 20:42

sys-fs/compsize: New ebuild

e4a8007

automorphism88 force-pushed the compsize branch from da15719 to e4a8007 Compare March 30, 2018 21:25

mgorny approved these changes Mar 30, 2018

View reviewed changes

gentoo-bot closed this in 6b6d7b9 Mar 30, 2018

automorphism88 deleted the compsize branch March 30, 2018 22:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

sys-fs/compsize: New ebuild (proxy maintainer) #7660

sys-fs/compsize: New ebuild (proxy maintainer) #7660

automorphism88 commented Mar 27, 2018

gentoo-repo-qa-bot commented Mar 27, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

automorphism88 commented Mar 30, 2018

mgorny left a comment

mgorny Mar 30, 2018

mgorny Mar 30, 2018

mgorny Mar 30, 2018

automorphism88 commented Mar 30, 2018

mgorny commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

gentoo-repo-qa-bot commented Mar 30, 2018

mgorny commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

mgorny commented Mar 30, 2018

sys-fs/compsize: New ebuild (proxy maintainer) #7660

sys-fs/compsize: New ebuild (proxy maintainer) #7660

Conversation

automorphism88 commented Mar 27, 2018

gentoo-repo-qa-bot commented Mar 27, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

automorphism88 commented Mar 30, 2018

mgorny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

automorphism88 commented Mar 30, 2018

mgorny commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

gentoo-repo-qa-bot commented Mar 30, 2018

mgorny commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

automorphism88 commented Mar 30, 2018

mgorny commented Mar 30, 2018